On Wed, 02 Mar 2005 11:52:42 -0700, Dax Kelson <dax@xxxxxxxxxxxx> wrote: > -------- Forwarded Message -------- > From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Reply-To: dtor_core@xxxxxxxxxxxxx > To: MIGUELANXO@xxxxxxxxxxxxxx <MIGUELANXO@xxxxxxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: 2.6.11: touchpad unresponsive > Date: Wed, 2 Mar 2005 12:12:53 -0500 > > Booting X in new kernel makes my touchpad very unresponsive. I can't > > click any longer in the touchpad area, and the touchpad doesn't response > > when moving in small increments, so the whole experience is quite bad. > If it is identified as an ALPS touchpad you can try installing Peter > Osterlund's Synaptics X driver: > > http://web.telia.com/~u89404340/touchpad/ Load of bull! See the attached patch for real fix for "no motion for small increments" problem. It's a kernel bug, plain and simple (provided that your ALPS was identified in the first place, just like Dmitry said). Actually, using Peter's driver is a good idea and I'll be happy to see it packaged and shipping. But it's retarded to use it in order to cover for obvious bugs. -- Pete diff -urp -X dontdiff linux-2.6.11-rc4/drivers/input/mousedev.c linux-2.6.11-rc4-lem/drivers/input/mousedev.c --- linux-2.6.11-rc4/drivers/input/mousedev.c 2005-02-15 22:38:39.000000000 -0800 +++ linux-2.6.11-rc4-lem/drivers/input/mousedev.c 2005-02-15 22:54:35.000000000 -0800 @@ -71,6 +71,7 @@ struct mousedev { struct mousedev_hw_data packet; unsigned int pkt_count; int old_x[4], old_y[4]; + int frac_dx, frac_dy; unsigned long touch; }; @@ -117,24 +118,31 @@ static struct mousedev mousedev_mix; static void mousedev_touchpad_event(struct input_dev *dev, struct mousedev *mousedev, unsigned int code, int value) { - int size; + int size, tmp; + enum { FRACTION_DENOM = 100 }; if (mousedev->touch) { + size = dev->absmax[ABS_X] - dev->absmin[ABS_X]; + if (size == 0) size = xres; switch (code) { case ABS_X: - size = dev->absmax[ABS_X] - dev->absmin[ABS_X]; - if (size == 0) size = xres; fx(0) = value; - if (mousedev->pkt_count >= 2) - mousedev->packet.dx = ((fx(0) - fx(1)) / 2 + (fx(1) - fx(2)) / 2) * xres / (size * 2); + if (mousedev->pkt_count >= 2) { + tmp = ((value - fx(2)) * (250 * FRACTION_DENOM)) / size; + tmp += mousedev->frac_dx; + mousedev->packet.dx = tmp / FRACTION_DENOM; + mousedev->frac_dx = tmp - mousedev->packet.dx * FRACTION_DENOM; + } break; case ABS_Y: - size = dev->absmax[ABS_Y] - dev->absmin[ABS_Y]; - if (size == 0) size = yres; fy(0) = value; - if (mousedev->pkt_count >= 2) - mousedev->packet.dy = -((fy(0) - fy(1)) / 2 + (fy(1) - fy(2)) / 2) * yres / (size * 2); + if (mousedev->pkt_count >= 2) { + tmp = ((fy(2) - value) * (250 * FRACTION_DENOM)) / size; + tmp += mousedev->frac_dy; + mousedev->packet.dy = tmp / FRACTION_DENOM; + mousedev->frac_dy = tmp - mousedev->packet.dy * FRACTION_DENOM; + } break; } } @@ -268,6 +276,8 @@ static void mousedev_touchpad_touch(stru clear_bit(0, &mousedev_mix.packet.buttons); } mousedev->touch = mousedev->pkt_count = 0; + mousedev->frac_dx = 0; + mousedev->frac_dy = 0; } else if (!mousedev->touch)
