On Tue, Apr 30, 2019 at 12:38 PM Kalev Lember <kalevlember@xxxxxxxxx> wrote: > > On Mon, Apr 29, 2019 at 9:20 PM Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote: >> >> On Mon, Apr 29, 2019 at 02:00:41PM -0500, Rex Dieter wrote: >> > Zbigniew Jędrzejewski-Szmek wrote: >> > >> > >> > > Proposal: let's drop the autogenerated dependency on /usr/bin/pkg-config >> > > (this would require a trivial change in /usr/lib/rpm/pkgconfigdeps.sh). >> > > >> > > Note: autogenerated Provides/Requires like pkgconfig(foo) are not >> > > part of this proposal. >> > > >> > > Advantages: >> > > - less entries in the dependency graph >> > > - removal of illogical dependency >> > > - less packages installed (pkgconf, pkgconf-m4, pkgconf-pkg-config, >> > > libpkgconf) >> > > (Those packages are small, maybe 200k together so this isn't a strong >> > > reason.) >> > > >> > > Disadvantages: >> > > - stuff that uses pkg-config or pkgconf will need to grow a dependency >> > > (e.g. meson which invokes /usr/bin/pkg-config internally). >> > > so there will be some churn. >> > >> > The work required to fix packages affected by this disadvantage >> > (potentially) far outweighs any advantage >> > >> > Now, if the proposal includes offering to help do a some/most of the work to >> > fix all these, then I withdraw the objection. >> >> Obviously. I would do most of the work myself. > > > I think it would make sense to avoid the autogenerated dep just for the directory ownership. It's a fairly tedious thing to change though: update %files lists for each package that ships .pc files, update build requires for packages that now need to list BuildRequires: pkg-config, update the rpm dep generator. And then after all of that is done, verify that things still build, now that the autogenerated dep is gone from everything in the build root. It's a lot of changes to make, but if you want to go through the pain of doing all of that then I don't mind :) > > Also, what should the BR be? > BuildRequires: /usr/bin/pkg-config > BuildRequires: pkg-config > BuildRequires: pkgconfig > BuildRequires: pkgconf > BuildRequires: pkgconf-pkg-config > If we're going to go down this road, it should be BuildRequires: /usr/bin/pkg-config That's what's required for the dep generator to work, too. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
