On Fri, Mar 8, 2019 at 12:29 PM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote:
>
> There is a FedoraReview port to Python 3 that needs real word testing by packagers.
>
> When you use FedoraReview, please use the Python 3 port instead to help us find
> bugs.
>
> Instructions are at https://pagure.io/FedoraReview/pull-request/312 -> the first
> comment of my Pull Request is updated with up to date instructions.
Attached are two automated reviews for playerctl, and if you look at
the diff you may notice that some things are gone, some things moved
around, some false-positives disappeared and when order of things
changed (eg. listing sub-packages) it's usually better now.
Overall it seems in better shape and more in sync with the current
guidelines, so thanks a lot!
Dridi
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License (v3
or later)". 21 files have unknown license. Detailed output of
licensecheck in
/home/dridi/fedora/FedoraReview/1671571-playerctl/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/include/playerctl, /usr/share/gtk-
doc/html/playerctl
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/girepository-1.0,
/usr/share/gir-1.0, /usr/share/gtk-doc/html/playerctl,
/usr/include/playerctl, /usr/share/gtk-doc, /usr/share/gtk-doc/html
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: playerctl-static.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
playerctl , playerctl-static , playerctl-debuginfo , playerctl-
debugsource
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: playerctl-2.0.1-7.fc31.x86_64.rpm
playerctl-devel-2.0.1-7.fc31.x86_64.rpm
playerctl-docs-2.0.1-7.fc31.noarch.rpm
playerctl-libs-2.0.1-7.fc31.x86_64.rpm
playerctl-static-2.0.1-7.fc31.x86_64.rpm
playerctl-debuginfo-2.0.1-7.fc31.x86_64.rpm
playerctl-debugsource-2.0.1-7.fc31.x86_64.rpm
playerctl-2.0.1-7.fc31.src.rpm
playerctl.x86_64: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness
playerctl.x86_64: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective
playerctl.x86_64: W: spelling-error %description -l en_US spotify -> spottily
playerctl.x86_64: W: spelling-error %description -l en_US vlc -> vac, VLF
playerctl.x86_64: W: spelling-error %description -l en_US bmp -> mp, bump, imp
playerctl.x86_64: W: spelling-error %description -l en_US cmus -> cums, mus, emus
playerctl-devel.x86_64: W: no-documentation
playerctl-libs.x86_64: W: no-documentation
playerctl-static.x86_64: W: no-documentation
playerctl.src: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness
playerctl.src: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective
playerctl.src: W: spelling-error %description -l en_US spotify -> spottily
playerctl.src: W: spelling-error %description -l en_US vlc -> vac, VLF
playerctl.src: W: spelling-error %description -l en_US bmp -> mp, bump, imp
playerctl.src: W: spelling-error %description -l en_US cmus -> cums, mus, emus
8 packages and 0 specfiles checked; 0 errors, 15 warnings.
Rpmlint (debuginfo)
-------------------
Checking: playerctl-debuginfo-2.0.1-7.fc31.x86_64.rpm
playerctl-libs-debuginfo-2.0.1-7.fc31.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.utf8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.utf8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.utf8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
playerctl-static.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-static.x86_64: W: no-documentation
playerctl.x86_64: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness
playerctl.x86_64: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective
playerctl.x86_64: W: spelling-error %description -l en_US spotify -> spottily
playerctl.x86_64: W: spelling-error %description -l en_US vlc -> vac, VLF
playerctl.x86_64: W: spelling-error %description -l en_US bmp -> mp, bump, imp
playerctl.x86_64: W: spelling-error %description -l en_US cmus -> cums, mus, emus
playerctl.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-libs.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-libs.x86_64: W: no-documentation
playerctl-docs.noarch: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-devel.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-devel.x86_64: W: no-documentation
playerctl-debuginfo.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-libs-debuginfo.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-debugsource.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
8 packages and 0 specfiles checked; 0 errors, 17 warnings.
Source checksums
----------------
https://github.com/acrisci/playerctl/releases/download/v2.0.1/playerctl-2.0.1.tar.xz :
CHECKSUM(SHA256) this package : c3ae6d74ddd951767da4e7852a76a88a2920ed02f126dab6e3b6f0c77549c74f
CHECKSUM(SHA256) upstream package : c3ae6d74ddd951767da4e7852a76a88a2920ed02f126dab6e3b6f0c77549c74f
Requires
--------
playerctl (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libplayerctl.so.2()(64bit)
playerctl-libs(x86-64)
rtld(GNU_HASH)
playerctl-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
libplayerctl.so.2()(64bit)
pkgconfig(gio-2.0)
pkgconfig(gio-unix-2.0)
pkgconfig(gobject-2.0)
playerctl(x86-64)
playerctl-docs (rpmlib, GLIBC filtered):
playerctl(x86-64)
playerctl-libs (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
playerctl(x86-64)
rtld(GNU_HASH)
playerctl-static (rpmlib, GLIBC filtered):
playerctl-devel(x86-64)
playerctl-debuginfo (rpmlib, GLIBC filtered):
playerctl-debugsource (rpmlib, GLIBC filtered):
Provides
--------
playerctl:
playerctl
playerctl(x86-64)
playerctl-devel:
pkgconfig(playerctl)
playerctl-devel
playerctl-devel(x86-64)
playerctl-docs:
playerctl-docs
playerctl-libs:
libplayerctl.so.2()(64bit)
playerctl-libs
playerctl-libs(x86-64)
playerctl-static:
playerctl-static
playerctl-static(x86-64)
playerctl-debuginfo:
debuginfo(build-id)
playerctl-debuginfo
playerctl-debuginfo(x86-64)
playerctl-debugsource:
playerctl-debugsource
playerctl-debugsource(x86-64)
Generated by fedora-review 0.6.1 (37b2325) last change: 2019-03-10
Command line :try-fedora-review -b 1671571 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: R, SugarActivity, PHP, Python, Haskell, Ocaml, Perl, Java, Ruby, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Header files in -devel subpackage, if present.
Note: playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/playerctl/playerctl-common.h
playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/playerctl/playerctl-
formatter.h playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/playerctl/playerctl-player-
manager.h playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/playerctl/playerctl-player-
name.h playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/playerctl/playerctl-player.h
playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/x86_64-redhat-linux-
gnu/playerctl/playerctl-enum-types.h playerctl-debugsource :
/usr/src/debug/playerctl-2.0.1-7.fc31.x86_64/x86_64-redhat-linux-
gnu/playerctl/playerctl-generated.h
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in playerctl-libs
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
===== MUST items =====
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GNU Lesser General Public License (v3 or later)", "Unknown or
generated". 21 files have unknown license. Detailed output of
licensecheck in /home/dridi/fedora/1671571-playerctl/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gtk-doc/html/playerctl,
/usr/include/playerctl
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gir-1.0, /usr/share
/gtk-doc/html/playerctl, /usr/share/gtk-doc, /usr/include/playerctl,
/usr/share/gtk-doc/html, /usr/lib64/girepository-1.0
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/.build-id(qemu-ui-
gtk, cups-client, hitch, efivar-libs, rsyslog, lz4-libs, qemu-block-
gluster, rpm-plugin-selinux, ghc-transformers, libimagequant, giflib,
libreoffice-graphicfilter, xsel, trousers, ots-libs, java-openjdk-
devel, libdb-utils, xorg-x11-font-utils, OpenEXR-libs, libcom_err,
libseccomp, alpine, p11-kit, libabw, gtkspell, libvirt-daemon-driver-
storage-iscsi, xfce4-dev-tools, libid3tag, libmodman, xdotool, claws-
mail-plugins-smime, parted, gnome-disk-utility, libdvdread, zstd,
bluez-libs, libbs2b, kf5-kjobwidgets, libwebp, libxslt, netty-
tcnative, system-config-printer-udev, perl-Encode, libverto-libev,
python2-cryptography, kf5-kdeclarative, libevdev, libgpg-error,
libmaxminddb, lvm2-libs, kf5-sonnet-core, libpurple, perl-Digest-SHA,
perl-Params-Classify, libmicrohttpd, libsodium, python3-unbound,
kf5-solid, libzstd, gtk-murrine-engine, libdazzle, lua-lpeg, symlinks,
python3-crypto, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-
libs, claws-mail-plugins-attachwarner, libdwarf, ltrace, source-
highlight, tpm2-tools, lcms2, docker-rhel-push-plugin, qemu-guest-
agent, annobin, ntfs-3g, libxcb, libyubikey, python3-pycurl,
openconnect, mingw64-binutils, xcb-util-keysyms, m4, samba-client-
libs, xfce4-systemload-plugin, perl-GSSAPI, rtorrent, libgphoto2,
rubygem-unf_ext, cdparanoia, xcb-util, libwmf-lite, libabiword, xfce4
-pulseaudio-plugin, udisks2-iscsi, python3-coverage, gstreamer1-vaapi,
userspace-rcu, http-parser, qt5-qtspeech, pulseaudio-utils, perl-Sub-
Identify, llvm5.0-libs, perl-PerlIO-utf8_strict, kf5-kdelibs4support-
libs, libeot, compat-wxGTK3-gtk2, systemd-bootchart, xxhash-libs,
kf5-kpackage, perl-Ref-Util-XS, perl-Time-Piece, xfdesktop, dbusmenu-
qt, ncurses-libs, polkit, ldns, thunar-volman, fcoe-utils, xorg-x11
-xkb-utils, ibus-hangul, native-platform, perl-IO-Tty, NetworkManager-
openvpn, libxkbfile, hplip-libs, libwvstreams, ghc-binary, kf5
-kglobalaccel-libs, xmlrpc-c-client, oci-systemd-hook, libwpg, libwpd,
enchant2, libdc1394, libvirt-daemon-driver-qemu, mbedtls, perl-Time-
HiRes, qemu-block-ssh, libwps, python3-lz4, gssdp, faad2-libs,
kf5-knotifications, robodoc, moreutils, libSM, policycoreutils, qemu-
block-iscsi, mcelog, samba-common-tools, libgdiplus, ghc-unix, perl-
Digest-SHA3, perl-Digest-SHA1, sane-backends-drivers-scanners,
libXxf86misc, foomatic, python3-reportlab, minizip, gvfs,
libpath_utils, libicu-devel, ocaml-num, rpm-build, libcangjie,
libglvnd-gles, python3-audit, rpm-plugin-systemd-inhibit, libmicrodns,
zerofree, claws-mail-plugins-archive, freeglut, gstreamer1, bsdtar,
msgpack, gmime30, libtomcrypt, webkit2gtk3-plugin-process-gtk2,
ccache, sshpass, libreoffice-gtk3, aiksaurus, librtmp, cairo-gobject,
libkkc, libclastfm, gstreamer-plugins-fc, gutenprint, openal-soft,
usermode, xarchiver, qpdf-libs, linux-atm-libs, libedit, ghc-hashable,
subversion-libs, atk, python3-cairo, python2-libdnf, wine-core,
accountsservice, ghc-containers, isl, ghc-integer-logarithms, hfsplus-
tools, ImageMagick, gssproxy, mesa-libGLU, libblockdev-btrfs,
libatomic_ops, python3-libs, clang6.0-libs, librepo, rubygem-io-
console, geany, libyui-ncurses, libvirt-daemon-driver-interface,
NetworkManager, libkate, liblangtag, NetworkManager-l2tp-gnome,
libdatrie, glade-libs, setuptool, kolourpaint-libs, gstreamer-plugins-
good, libasan, guile, mono-devel, pcre-utf16, tree, isdn4k-utils,
pipewire, glusterfs-libs, gnupg, libnsl2, libserf, xfsprogs,
authselect, libcroco, python2-zmq, xfce4-dict, NetworkManager-iodine,
telepathy-glib, NetworkManager-fortisslvpn-gnome, plymouth-plugin-
label, wildmidi-libs, colord-libs, aalib-libs, gstreamer1-libav,
libcddb, totem-pl-parser, gpgmepp, libgcab1, libzhuyin, perl-Unicode-
LineBreak, hypervfcopyd, cronie, libwnck, libexttextcat, libjpeg-
turbo-utils, qt5-qtquickcontrols, nettle, mingw64-gcc, libcacard,
caca-utils, colord, vmod-querystring, libpipeline, pkcs11-helper,
gstreamer-plugins-ugly, network-scripts, findutils, popt,
python2-xpyb, qt5-qtx11extras, libsss_idmap, imsettings-gsettings,
libraw1394, boost-atomic, lm_sensors, gcc-c++, python3-dbus, iproute-
tc, ghc-vector, libvterm, goffice, woff2, coolkey, dotconf,
libtimezonemap, jigdo, PackageKit-glib, patch, sqlite-libs, lttng-ust,
enchant, isync, kf5-plasma, libXxf86dga, python2-smartcols, rhash,
xdg-user-dirs-gtk, perl-Data-Dumper, libwayland-client, kf5-kio-file-
widgets, pinentry-gnome3, libsmbios, libipt, mdadm, python2-zope-
interface, python2-msgpack, device-mapper, python2-librepo, libXtst,
xapian-core-libs, python2-setproctitle, irqbalance, kf5-kbookmarks,
perl-Text-Soundex, GeoIP, perl-Class-XSAccessor, GraphicsMagick,
portaudio, python2-talloc, opencc, libXrandr, newt, liba52, hplip,
wine-twain, ghc-QuickCheck, argus, libupnp, crda, libical, sheepdog,
qt5-qtdeclarative, vo-amrwbenc, ElectricFence, qt5-qtquickcontrols2,
libofa, libXfont2, libblockdev-loop, libmfx, libssh2, byacc,
NetworkManager-adsl, open-vm-tools-desktop, xmlsec1-nss, dbusmenu-qt5,
libXcursor, nftables, bridge-utils, procps-ng, plymouth-core-libs,
telnet, libXpm, xorg-x11-drv-nouveau, bluez-obexd, zlib, libpeas,
gnustep-base-libs, pam_krb5, gutenprint-cups, gstreamer1-plugins-
entrans, avahi, libselinux, ncurses-compat-libs, libassuan, expat,
cups-filters, iw, cone, libblockdev-utils, wavpack, libbsd, live555,
ibus-libpinyin, setroubleshoot-server, make, python3-markupsafe,
libseccomp-devel, galculator, libnice, libsoup, xfce4-xkb-plugin,
libetpan, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, rrdtool,
cups-libs, slrn, libappstream-glib, whois-mkpasswd, libsepol, efivar,
gzip, qt5-linguist, python3-cangjie, keyutils, mhash, isomd5sum,
libfdisk, libdmx, openssl-libs, corosynclib, python2-wsaccel, dconf-
editor, libreport-plugin-reportuploader, libguestfs-tools-c,
libatasmart, ipset, x265-libs, libtermkey, kf5-kcoreaddons, libyui-
gtk, libcaca, keybinder3, deltarpm, fuse-libs, kf5-attica, xfce4
-weather-plugin, samba-client, java-11-openjdk, xorg-x11-xauth,
java-11-openjdk-headless, libglvnd-glx, pscan, umockdev, libXrender,
json-glib, kf5-kglobalaccel, libX11-xcb, libfontenc, libicu, libgsf,
xorg-x11-drv-vmware, xfce-polkit, NetworkManager-openconnect,
libgtop2, ctorrent, btrfs-progs, ristretto, wvdial, libtorrent, cogl,
sni-qt, openssh-askpass, mesa-libglapi, glx-utils, libtommath,
PackageKit, daxctl-libs, numad, polkit-qt5-1, elfutils, ssdeep-libs,
libass, ghc-time, python3-twisted, SDL_image, texlive-lib, ppp, sox,
libtiger, git, perl-Compress-Raw-Bzip2, slang-slsh, jack-audio-
connection-kit, python3-ujson, opus, ctags, tcpdump, zisofs-tools,
libxklavier, traceroute, cyrus-sasl-plain, dyninst, libblockdev-
crypto, gconfmm26, kf5-karchive, pcsc-lite-ccid, libreoffice-
pdfimport, xfce4-mount-plugin, rp-pppoe, libtheora, attr, mtr,
gtksourceview3, protobuf-c-compiler, pugixml, libcanberra-gtk2,
libcanberra-gtk3, kf5-ki18n, boost-program-options, mtdev, mailx,
systemd-udev, golang, libXvMC, mousepad, wmctrl, llvm, bmake,
python2-pillow, libXmu, libv4l, tin, wine-ldap, capstone, ocaml-
menhir, python3-zope-interface, libreoffice-impress, smartmontools,
jasper-libs, librbd1, gstreamer1-plugins-fc, device-mapper-libs,
xorg-x11-xinit, libogg, pyliblzma, libffi, libGLEW, pcre-utf32, perl-
File-FcntlLock, diffutils, libgnomecanvas, time, checkpolicy, mpfr,
ghc-array, cyrus-sasl-md5, iputils, qt5-qtxmlpatterns, numactl-libs,
libvirt-daemon-driver-nwfilter, recode, tigervnc-server-minimal,
paprefs, gpgme, ninja-build, hypervvssd, kf5-kded, xorg-x11-drv-
openchrome, libmcpp, libibverbs, gdb-headless, ghc-ghc-boot-th,
libgpg-error-devel, qemu-audio-pa, libqmi-utils, python2-chm, libmbim-
utils, psacct, lame-libs, libcomps, gnome-bluetooth-libs, VirtualBox,
usbredir, ghostscript, iproute, iptables-libs, cryptsetup-libs,
syslinux-extlinux, python2-gpg, bind-libs, pygobject2, antimicro, lua-
posix, libinput, iperf, libreport-cli, libpkgconf, mono-core,
python3-dmidecode, axel, libtsan, im-chooser, qt5-qtsvg, libreoffice-
calc, ghc-unordered-containers, libqmi, glade3-libgladeui, gawk,
dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects,
wine-cms, rdma-core, libgnomeui, vte291, zzuf, anaconda-widgets, wine-
opencl, nmap, brotli, libdvbpsi, httpd, libsmbclient, nes_ntsc,
python2-reportlab, transmission-gtk, getdns, libkcapi, libvdpau,
compat-openssl10, java-openjdk-headless, apper, opencore-amr,
libnftnl, sstp-client, oddjob-mkhomedir, network-manager-applet, xcb-
util-renderutil, rclone, lightdm, libpinyin, nmap-ncat, logrotate,
libkadm5, exo-devel, libdnet, ntfsprogs, appstream-qt, cbmc, protobuf,
efibootmgr, kf5-kio-ntlm, clang, samba-common-libs, libreswan, libpsl,
kf5-kconfig-gui, python3-rpm, alsa-lib, zbar, fwupdate-libs, jimtcl,
libuser, NetworkManager-libreswan, opensp, libnotify, graphviz, kexec-
tools, opensc, boost-date-time, python3-libdnf, cabextract, libglade2,
satyr, gts, schroot, pixman, gtk2-immodule-xim, kf5-kparts,
wpa_supplicant, xorg-x11-drv-vesa, libbluray, ghc-uuid-types, cifs-
utils, ghc-ShellCheck, libstdc++, libbabeltrace, mjpegtools-libs,
imsettings, systemd, vpnc, psmisc, net-snmp-libs, xorg-x11-drv-
libinput, mesa-libOSMesa, cscope, libblockdev-mpath, ed, ghc-process,
libgcc, gdisk, ilmbase, xfce4-settings, poppler, pocl, libstemmer,
whatmask, djvulibre-libs, claws-mail, ibus-libzhuyin, fftw-libs-
double, libconfig, ModemManager, xdelta, procmail, ibus-m17n,
gnumeric, qemu-img, qt5-qtbase-gui, ghc-pretty, xfce4-screenshooter,
rtkit, orc, libidn2, libuuid, ocaml, libarchive, libfreehand, ibus-
gtk3, ibus-gtk2, ghc-deepseq, python2-libselinux, cryptsetup, udisks2,
xfce4-dict-plugin, clucene-contribs-lib, mpg123-libs, paps-libs,
tcp_wrappers, xz, libXcomposite, rpcbind, mtools, pygtk2, xfce4
-sensors-plugin, criu, vim-minimal, harfbuzz-icu, libplist, gstreamer-
tools, libmimic, xdg-user-dirs, hwloc-libs, cproto, spice-server, gdk-
pixbuf2, gupnp, libreport, libevent, redland, python2-cccolutils,
pcsxr, git-core, aspell, link-grammar, zsh, setserial, libblockdev-
kbd, dash, imsettings-qt, libblockdev, mingw64-cpp, librdmacm, lua-
socket, dconf, xz-libs, dbus-glib, minisat2-libs, libdvdnav, libcap,
libprojectM, libvirt-daemon-driver-storage-zfs, libwbclient, compiler-
rt, kf5-kio-widgets-libs, libvirt-daemon-driver-storage-gluster,
python3-bcrypt, NetworkManager-fortisslvpn, NetworkManager-ssh-gnome,
libbonobo, mod_http2, libthai, perl-NKF, fakeroot, qt5-qttools-libs-
designer, nss-tools, libestr, libtirpc, java-openjdk,
python2-simplejson, ghc-aeson, libsmartcols, fakeroot-libs, cargo,
sane-backends-drivers-cameras, xfce4-verve-plugin, libva-intel-driver,
orc-compiler, chmlib, libyui-qt-graph, xfburn, os-prober, ethtool,
vorbis-tools, libfprint, systemd-libs, cpio, libknet1, libfdt,
gstreamer-devel, util-linux, libburn, apr-util-bdb, im-chooser-xfce,
krb5-libs, bison, net-tools, claws-mail-plugins-spam-report, htop,
llvm6.0-libs, libblockdev-part, libpciaccess, clucene-core, kmod,
xfdashboard, libxml++, NetworkManager-pptp, libetonyek, plymouth,
libgs, rubygem-ruby-libvirt, libgnome, python2-pwquality, sssd-client,
libgxps, screen, jq, kf5-kiconthemes, js, libpagemaker,
python3-snappy, libreport-plugin-bugzilla, webkit2gtk3-jsc,
kf5-kitemviews, libxkbcommon, miniupnpc, device-mapper-multipath-libs,
perl-XML-LibXML, yajl, lockdev, remake, cups-filters-libs, poppler-
utils, lpsolve, xorg-x11-server-utils, libacl, vid.stab, ghc-parsec,
libvirt-daemon-driver-storage-iscsi-direct, marisa, evince-libs,
libepubgen, dhex, xorg-x11-drv-ati, libdnf, ruby, gnome-keyring,
libdbusmenu-gtk3, pulseaudio-libs-glib2, rubygem-nokogiri, libnice-
gstreamer1, netpbm, nm-connection-editor, python3-pyparted,
libudisks2, gstreamer1-plugins-bad-free, NetworkManager-libreswan-
gnome, python3-setools, clutter, zenity, libFAudio, chkconfig,
libgnome-keyring, zsnes, hostname, xfce4-battery-plugin, check,
gparted, pptp, pangox-compat, librados2, libvirt-daemon-driver-
storage-mpath, subunit, ShellCheck, pam, python2-cffi, unixODBC,
openldap, kmod-VirtualBox-4.20.13-200.fc29.x86_64, oniguruma, libXft,
gamin, ipcalc, NetworkManager-team, speex, libvirt-daemon-driver-
storage-logical, neon, rest, perl-Want, libsamplerate, qt5-qtbase-
devel, python2-lxml, NetworkManager-vpnc-gnome, boost-iostreams,
pakchois, subversion, zfs-fuse, systemtap-runtime, libusbmuxd, perl-
Unicode-Normalize, libimobiledevice, lzop, NetworkManager-wwan, claws-
mail-plugins-newmail, polkit-pkla-compat, jbig2dec-libs, epiphany-
runtime, libmtp, compface, librevenge, iftop, xterm-resize, python3
-gobject-base, xfce4-appfinder, dnsmasq, libXfixes, libblkid, libcdio,
NetworkManager-l2tp, rsync, samba-winbind, chromium, lua-libs,
pavucontrol, perl-Params-Util, authselect-libs, soundtouch, xorg-x11
-drv-evdev, xfce4-netload-plugin, libXinerama, lirc-libs, libteam,
nmh, vim-enhanced, libcmis, libesmtp, acl, cudd, iodine-client,
libvirt-daemon-driver-storage-sheepdog, xfce4-session, ocaml-runtime,
redshift, gupnp-igd, kf5-kinit, splint, irssi, gstreamer-plugins-base,
libgee, libXxf86vm, unar, mesa-libEGL, clang-libs, systemd-pam, glpk,
ftgl, dolphin-emu, perl-Storable, perl-Digest-MD5, lua-term, libshout,
python2-hawkey, perl-Sort-Key, glib2-devel, libvirt-daemon-driver-
storage-rbd, nss-util, radvd, libsemanage, devscripts, cracklib, ghc-
primitive, rust, mozjs52, systemd-container, python3-lxml, gtk3-devel,
at, gtk3-immodule-xim, vamp-plugin-sdk, libdca, libblockdev-fs,
chrony, libblockdev-nvdimm, libnma, gettext, pcre2-utf32, soxr,
kf5-libksane, espeak, oci-umount, libutempter, libmetalink, slang,
python3-wsaccel, openblas-serial, protobuf-compiler, usbutils,
e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp, oprofile,
libksba, libwayland-server, virglrenderer, gdbm, libchromaprint,
libsndfile, libblockdev-vdo, libvisio, gstreamer-plugins-good-extras,
ghc-th-abstraction, tk, python3-sqlalchemy, ruby-libs, bzip2-libs,
NetworkManager-iodine-gnome, dbus-libs, gmp-c++, cadaver, openssl-
pkcs11, libreoffice-gtk2, gnutls, ncftp, device-mapper-persistent-
data, ykpers, ghc-json, libselinux-utils, perl-Scalar-List-Utils,
dosfstools, rng-tools, libspectre, gstreamer-plugins-bad-free-extras,
nano, keyutils-libs, libproxy, libreoffice-math, memcached, ghc-base,
glusterfs-fuse, game-music-emu, plymouth-graphics-libs, pidgin,
gstreamer-plugins-bad, anaconda-core, python2-sqlalchemy, xfce4
-clipman-plugin, libkworkspace5, libnfsidmap, perl-XML-Parser,
mlocate, tmux, file-libs, grub2-tools, perl-Locale-gettext, avahi-
glib, mokutil, libva, libblockdev-swap, libnetfilter_conntrack,
python3-gobject, libev, xfce4-datetime-plugin, bash, libxml2, fprintd-
pam, libXpresent, libusbx, NetworkManager-openvpn-gnome, qrencode-
libs, libICE, xfce4-places-plugin, flac, drpm, qemu-block-nfs,
createrepo_c-libs, kf5-kio-core, grilo, perl-Compress-Raw-Zlib,
libindicator-gtk3, speexdsp, abook, upower, java-1.8.0-openjdk-devel,
libwnck3-devel, p7zip, libreoffice-x11, xcb-util-wm, diffstat,
gtk2-devel, Thunar, openssl, gstreamer-plugins-base-tools, dbxtool,
gnome-vfs2, pragha, PackageKit-Qt5, gstreamer1-rtsp-server,
libtranslate, gstreamer1-plugins-good-gtk, hugo, libblockdev-lvm,
libwnck3, x264-libs, python2-gobject, opam-installer, gtkmm24,
libvirt-daemon-driver-storage-disk, mpage, mesa-dri-drivers,
gstreamer1-plugins-bad-free-fluidsynth, sgpio, libffado, plank,
suitesparse, trickle, gdbm-libs, fribidi, libgnomekbd, NetworkManager-
ssh, ocaml-ocamlbuild, ibus-rawcode, coan, pciutils, libini_config,
openssh-clients, itk, libX11, mate-desktop-libs, celt051, beignet,
libvkd3d, iscsi-initiator-utils, kyotocabinet-libs, python3-pwquality,
gvfs-mtp, python3-cryptography, gnome-bluetooth, ghc-template-haskell,
python3-msgpack, u2f-hidraw-policy, libnl3, pcc, libnatpmp,
NetworkManager-sstp, libidn, BackupPC, grubby, openjpeg-libs, xfce4
-cpugraph-plugin, python2-gssapi, python3-libreport, libdbusmenu,
libdbi, libbytesize, libmpeg2, qemu-block-rbd, python3-systemd, tokei,
libnl3-cli, aria2, ibus-libs, python2-libcomps, python2-pyyaml, fish,
audit-libs, perl-Text-CharWidth, cyrus-sasl-devel, bluez, wine-alsa,
gettext-libs, liborcus, kf5-kwidgetsaddons, qt5-qtwayland,
libref_array, astyle, fwupd, raptor2, gtk-update-icon-cache, xfce4
-mailwatch-plugin, libyui, plymouth-plugin-two-step, sbc, qt-x11, ghc-
random, libhangul, libbonoboui, ocl-icd, poppler-glib, pcaudiolib,
seahorse, audacity, utf8proc, orage, ibus-kkc, kf5-kxmlgui, lvm2,
openfortivpn, par2cmdline, harfbuzz, ghc-syb, SFML, cups, dmraid,
neovim, tpm2-abrmd, tokyocabinet, python3-wrapt, gvfs-client,
NetworkManager-libnm, urlview, Nestopia, python2-libs, zeromq, ibus-
qt, ocaml-findlib, pulseaudio, lrzsz, libglvnd-egl, opusfile,
python3-newt, dhcp-libs, dpkg, libtalloc, grep, hypervkvpd, perl-Sys-
Syslog, libepoxy, kf5-kdelibs4support, perl-Variable-Magic, man-db,
python2-dbus, gedit, libvirt-daemon-driver-storage-core, imsettings-
xfce, libibumad, libgadu, gnome-desktop3, liblogging-stdlog,
timedatex, fltk, rasqal, wireless-tools, libdb, xfce4-fsguard-plugin,
passwd, cups-pk-helper, quota, kmod-libs, SDL, libdv, gutenprint-libs,
lm_sensors-libs, libreoffice-writer, desktop-file-utils, libXdamage,
NetworkManager-ppp, ghc-directory, xorg-x11-utils, libmwaw, libusal,
sombok, libunwind, gtkmm30, unbound-libs, clang5.0-libs, libxfce4ui,
gobject-introspection, kf5-kconfig-core, libpwquality, fontconfig,
compat-ffmpeg28, patchutils, libnsl, jbigkit-libs, ghc-mtl, compat-
lua-libs, evince-djvu, libkcapi-hmaccalc, libtar, libdaemon, ffmpeg,
libytnef, caja-core-extensions, python3-librepo, pkgconf,
python2-snappy, json-c, kf5-kauth, sed, pygtk2-libglade, arj,
jemalloc, perl-threads-shared, glib-networking, samba-libs, kpartx,
libpng, sane-backends-libs, python3-pillow, deletemail, cyrus-sasl,
hardlink, libcollection, libgcrypt, v4l-utils-devel-tools,
xfce4-taskmanager, opam, cairomm, perl-Unicode-UTF8, kf5-kwallet, nss-
softokn, openal-soft-devel, geoclue2, lsof, bonnie++, at-spi2-atk,
loudmouth, cronie-anacron, twolame-libs, cups-ipptool, xorg-x11
-server-Xorg, libmbim, python2-lz4, perl-IO, libomp, libverto,
glibmm24, gtk-xfce-engine, libXScrnSaver, libtasn1-tools, realmd,
libmspub, varnish, ncurses, nfs-utils, graphite2, python3-kerberos,
perl-List-MoreUtils-XS, passwdqc-lib, imlib2, libmad, libde265,
gstreamer-plugins-bad-free, ndctl-libs, coccinelle, gmp, volume_key-
libs, b43-fwcutter, libmodulemd1, farstream02, ffmpeg-libs, alsa-
plugins-pulseaudio, perl-interpreter, bluez-cups, rubygem-ffi,
chromium-libs-media, libcurl, kf5-kcrash, coreutils, libcap-ng, xfce4
-screenshooter-plugin, mediawriter, dbus-x11, plank-libs, itcl,
pinentry, libvirt-daemon-driver-storage-scsi, yafc, libmpcdec, lua-
filesystem, libubsan, qemu-common, docker, gsm, libuv, boost-
filesystem, libtevent, kf5-sonnet-ui, samba-winbind-clients, ghc-base-
compat, libvmaf, libglvnd, gobject-introspection-devel, boost-system,
libpcap, nspr, wxBase3, im-chooser-common, snappy, libxdo, xterm,
cyrus-sasl-lib, libfc14audiodecoder, genisoimage, ghc-regex-base,
libgcrypt-devel, rubygem-bigdecimal, pcre2, openssh, xmlrpc-c,
jsoncpp, perl-TermReadKey, espeak-ng, protobuf-c, libpng-devel, perl-
MIME-Base64, wine-capi, libmspack, courier-unicode, libssh, GConf2,
glibc, opencl-utils, xz-lzma-compat, epic, ttmkfdir, fipscheck,
mactel-boot, bc, ghc-bytestring, gdk-pixbuf2-devel, wget, libijs,
boost-regex, ghc-filepath, python2-unbound, libreport-web, libgomp,
libexif, libvirt-daemon-driver-secret, gstreamer1-plugins-bad-
freeworld, tigervnc, libgusb, glib2, hesiod, spirv-tools-libs, qemu-
system-x86-core, ImageMagick-libs, libwmf, pcre2-utf16, libmnl,
gettext-devel, libzmf, libmng, nss, pcre, tcp_wrappers-libs, sane-
backends, gstreamer1-plugins-base, nghttp2, speech-dispatcher,
PackageKit-gstreamer-plugin, pciutils-libs, ghc-attoparsec, libmpc,
libXi, openjpeg2, libmatroska, flac-libs, libXt, libXv, rubygem-
openssl, rpm-libs, info, libnfnetlink, ghc-time-locale-compat,
libiec61883, gstreamer, NetworkManager-sstp-gnome, rpm-sign-libs,
device-mapper-event, exo, nscd, highlight, mingw32-cpp, thunar-media-
tags-plugin, lightdm-gtk, qt5-qtbase, ghc-scientific, kolourpaint,
libreoffice-base, libpskc, linux-atm, ibus, libglademm24, jwhois,
qemu-block-dmg, curl, yelp-libs, cmake, gnutls-dane, rubygem-json,
claws-mail-plugins-rssyl, gcc-gdb-plugin, fipscheck-lib, usbguard,
pilot-link-libs, scrub, python2-pycurl, dos2unix, paps, libqxp, lzo-
minilzo, harfbuzz-devel, tpm2-tss, qt5-qtspeech-speechd, geany-
libgeany, gnome-keyring-pam, nasm, imsettings-libs, zchunk-libs, gd,
gc, python3-cups, libxshmfence, ncurses-c++-libs, ghc-text, gstreamer1
-plugins-ugly-free, atlas, lftp, unzip, apr-util-openssl, vlc, gtk2,
gtk3, libwayland-egl, gtk+, xfce4-session-engines, atkmm, npth,
systemtap-client, libyaml, mercurial, libXaw, claws-mail-plugins-
notification, gspell, xcb-util-image, m17n-lib, fetchmail,
libblockdev-mdraid, glusterfs, xmlstarlet, libebml, xfce4-time-out-
plugin, libunistring, gstreamer1-plugins-good-extras, reiserfs-utils,
gstreamer1-plugins-good, python2-rpm, libasyncns, qemu-block-curl,
device-mapper-multipath, c-ares, xmlsec1-openssl, python2-cairo,
NetworkManager-pptp-gnome, jansson, bind-utils, garcon, libpeas-gtk,
librsvg2, firefox, alsa-utils, apr, libsss_nss_idmap, apt, trousers-
lib, libnumbertext, libaom, zip, webrtc-audio-processing, bcache-
tools, startup-notification, libstaroffice, pinfo, gstreamer1-plugins-
bad-free-wildmidi, xfce4-panel, phonon-qt5-backend-gstreamer,
bubblewrap, elfutils-libs, speech-dispatcher-espeak-ng, libtasn1,
libblockdev-dm, libe-book, iptables, sqlite, tar, kf5-kservice, SOIL,
sudo, dhcp-client, fprintd, pinentry-gtk, gcc, mingw32-gcc, lame, dwz,
meanwhile, xorg-x11-drv-qxl, cyrus-sasl-scram, gnupg2, oddjob,
ebtables, libyui-qt, avahi-libs, pigz, python3-pyyaml,
libappindicator-gtk3, xfce4-eyes-plugin, libquvi, gvfs-archive,
thunar-archive-plugin, libao, enet, tinyxml2, insight, systemtap-
devel, lz4, kbd, tcl, mutt, dbus-daemon, libreoffice-core, wayland-
devel, gnupg2-smime, scanmem, gcr, libwayland-cursor, playerctl, flex,
squashfs-tools, chromium-libs, gstreamer1-plugins-ugly, xvidcore,
libwacom, lzo, pango, libss, libshaderc, BackupPC-XS, esmtp,
VirtualBox-server, polkit-libs, perl-threads, perl-Params-Validate,
python2-newt, pangomm, kf5-kguiaddons, mesa-libxatracker, lzma-libs,
nss-sysinit, libxfce4ui-devel, unibilium, claws-mail-plugins-
vcalendar, tcsh, python3-cffi, openjade, kf5-kwallet-libs, at-
spi2-core, libvirt-daemon-driver-network, glibc-common, liblockfile,
indent, ocaml-pcre, gstreamer1-plugins-bad-free-extras, kf5-kcodecs,
clang-tools-extra, kmod-VirtualBox-4.20.14-200.fc29.x86_64, bind-
export-libs, kf5-kwindowsystem, ndctl, bamf, claws-mail-plugins-
mailmbox, kf5-kactivities, python3-libxml2, libnfs, python3-hawkey,
libgfortran, stoken-libs, libiscsi, texlive-kpathsea, groff-base,
mesa-libgbm, ghc-dlist, libusb, hddtemp, mesa-libGL, perl-Devel-
LexAlias, perl-HTML-Parser, libldb, wine-devel, libldm, bind-libs-
lite, NetworkManager-vpnc, libmodplug, libvirt-daemon-driver-nodedev,
libXres, samba-winbind-modules, libcanberra, libobjc, pcsc-lite, kf5
-kio-core-libs, grub2-tools-efi, libdav1d, libart_lgpl, libgudev,
xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, libmemcached-libs,
qt5-qtscript, which, boost-chrono, libmemcached, libaio, lua-expat,
gstreamer-plugins-espeak, python3-cccolutils, libquadmath,
libxfce4util, qemu-ui-curses, t1lib, python2-krbv, brlapi, strace,
createrepo_c, python2-markupsafe, python2-ujson, elinks,
xfce4-screensaver, libreport-gtk, liboauth, lmdb-libs, mingw-binutils-
generic, xl2tpd, xmlsec1, xfce4-power-manager, libmodsecurity, isns-
utils-libs, libIDL, libwsman1, openldap-clients, krb5-workstation,
perl-libs, ksh, freetype, libglvnd-opengl, slv2, vlc-core, wine-
openal, lksctp-tools, fceux, usb_modeswitch, tbb, mythes, rubygem-
psych, NetworkManager-wifi, qt, libfastjson, mate-terminal,
gnutls-c++, teamd, libvorbis, claws-mail-plugins-tnef, varnish-
modules, lightdm-gobject, NetworkManager-openconnect-gnome, vconfig,
pcre-tools, pcre-cpp, python3-libselinux, libodfgen, mingw32-binutils,
xfce4-notifyd, yash, ORBit2, yasm, lua, gtest, caja, cppcheck, perl-
PadWalker, xfce4-whiskermenu-plugin, ghc-regex-tdfa, libpeas-loader-
python3, pulseaudio-module-gconf, american-fuzzy-lop, llvm-libs,
doxygen, asunder, pulseaudio-module-bluetooth, wv, libvirt-libs,
valgrind, kf5-kconfigwidgets, qt5-qtgraphicaleffects, libcdaudio,
xfce4-diskperf-plugin, libsigc++20, passwdqc, ghc-tagged,
schroedinger, libattr, pulseaudio-module-gsettings, hyphen, zvbi, rpm,
qemu-audio-oss, syslinux, abiword, scanmem-libs, libxcrypt, iptstate,
claws-mail-plugins-fetchinfo, trinity, libplacebo, kf5-kdbusaddons,
openpgm, openvpn, gtk-unico-engine, appstream, glusterfs-cli, perl-
PathTools, ipset-libs, kf5-kio-widgets, bluez-tools, lasem, glusterfs-
client-xlators, libreoffice-pyuno, hexedit, file, libpaper,
python2-libuser, libreoffice-ure, python3-pyaudio, iscsi-initiator-
utils-iscsiuio, cyrus-sasl-gssapi, hivex, xfwm4, xfce4-about,
libargon2, mesa-vulkan-drivers, libvirt-daemon, protobuf-lite,
libsecret, tumbler, gtk2-engines, bamf-daemon, libnet, p11-kit-trust,
NetworkManager-bluetooth, kf5-kcompletion, augeas-libs, libsysfs,
lasi, libxmlb, tftp, audit, xfce4-terminal, java-1.8.0-openjdk-
headless, boost-locale, gdk-pixbuf2-modules, binutils, xfconf, xen-
libs, libisofs, perl-DateTime, nss-pem, vim-common, python2-kerberos,
less, brltty, libvpx, evince, rpm-build-libs, libnghttp2, util-linux-
user, libsolv, exempi, libxkbcommon-x11, libmms, libtdb, python3-gpg,
libXdmcp, perl-Socket, apr-util, krb5-devel, libdrm, libatomic,
libvisual, uncrustify, kf5-kunitconversion, python3, python2, gpm-
libs, kf5-kwayland, minicom, unrar, supermin, perl-DB_File, dbus-
tools, shared-mime-info, httpd-tools, SDL2, webkit2gtk3, perl-GD,
python2-twisted, libsigsegv, keepassxc, boost-thread, perl-Devel-
Caller, plank-docklets, shadow-utils, kmod-
VirtualBox-4.20.11-200.fc29.x86_64, libcgroup, perl-Filesys-Df, dbus-
glib-devel, libXau, netcf-libs, phonon-qt5, pulseaudio-module-x11,
dmidecode, qemu-audio-alsa, python3-libcomps, gfs2-utils, perl-Devel-
CallChecker, libjpeg-turbo, wine-pulseaudio, libmount, epiphany,
spice-vdagent, xorg-x11-drv-wacom-serial-support, xorg-x11-drv-fbdev,
libqb, libavc1394, lldpad, libtiff, python3-libsemanage, libvncserver,
claws-mail-plugins-pgp, ima-evm-utils, w3m, java-1.8.0-openjdk, cairo,
ghc-tf-random, python2-gobject-base, mesa-libOpenCL, glib, grub2
-tools-extra, transmission-common, qemu-audio-sdl, openssh-server,
fluidsynth-libs, taglib, PackageKit-gtk3-module, libXext, mcpp,
ModemManager-glib, dracut, device-mapper-event-libs, initscripts,
hunspell, lynx, libieee1284, libndp, claws-mail-plugins-att-remover,
xorg-x11-drv-intel, gstreamer1-plugins-base-tools, libguestfs,
manedit, qemu-ui-sdl, lsscsi, kf5-ktextwidgets, bzip2, elfutils-
libelf, nss-softokn-freebl, rsync-bpc, open-vm-tools, android-tools,
kf5-kdoctools, python3-smartcols, libavdevice, nss-mdns, xfce4-genmon-
plugin, libtool-ltdl, readline, yelp, libtimidity, vulkan-loader,
perl-version, parole), /usr/lib/.build-id/d8(xfce4-power-manager,
gstreamer1-plugins-bad-free, ImageMagick-libs, graphviz, ghc-json,
perl-interpreter, libsamplerate, opencc, wine-core, glibc, gstreamer-
plugins-ugly, tokyocabinet, shadow-utils, VirtualBox-server,
gstreamer1-plugins-ugly-free, xz-lzma-compat, libreoffice-math,
liblangtag, iptables, lftp, llvm, chromium-libs, gstreamer1-plugins-
good, python3-libs, vlc-core, libnl3, gstreamer-plugins-good, mesa-
libGL, util-linux, xorg-x11-xauth, clang-libs, libtasn1, pulseaudio,
libexif, polkit-qt5-1, ppp, net-tools, glib2, libcanberra, samba-
client-libs, libieee1284), /usr/lib/.build-id/a7(mesa-libGLU,
gstreamer1-plugins-bad-free, libvkd3d, keepassxc, openldap-clients,
wine-core, glibc, libibverbs, shadow-utils, speech-dispatcher, java-
openjdk-headless, freetype, llvm, chromium-libs, NetworkManager-sstp,
gstreamer-plugins-espeak, unixODBC, moreutils, at-spi2-core, quota,
gstreamer1-plugins-good, polkit, xl2tpd, python2-sqlalchemy, aspell,
java-1.8.0-openjdk-devel, isdn4k-utils, libpeas, accountsservice,
clang-libs, binutils, java-11-openjdk-headless)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: playerctl-static.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
playerctl-static , playerctl-debuginfo , playerctl-debugsource
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: playerctl-2.0.1-7.fc31.x86_64.rpm
playerctl-devel-2.0.1-7.fc31.x86_64.rpm
playerctl-docs-2.0.1-7.fc31.noarch.rpm
playerctl-libs-2.0.1-7.fc31.x86_64.rpm
playerctl-static-2.0.1-7.fc31.x86_64.rpm
playerctl-debuginfo-2.0.1-7.fc31.x86_64.rpm
playerctl-debugsource-2.0.1-7.fc31.x86_64.rpm
playerctl-2.0.1-7.fc31.src.rpm
playerctl.x86_64: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness
playerctl.x86_64: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective
playerctl.x86_64: W: spelling-error %description -l en_US spotify -> spottily
playerctl.x86_64: W: spelling-error %description -l en_US vlc -> vac, VLF
playerctl.x86_64: W: spelling-error %description -l en_US bmp -> mp, bump, imp
playerctl.x86_64: W: spelling-error %description -l en_US cmus -> cums, mus, emus
playerctl-devel.x86_64: W: no-documentation
playerctl-libs.x86_64: W: no-documentation
playerctl-static.x86_64: W: no-documentation
playerctl.src: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness
playerctl.src: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective
playerctl.src: W: spelling-error %description -l en_US spotify -> spottily
playerctl.src: W: spelling-error %description -l en_US vlc -> vac, VLF
playerctl.src: W: spelling-error %description -l en_US bmp -> mp, bump, imp
playerctl.src: W: spelling-error %description -l en_US cmus -> cums, mus, emus
8 packages and 0 specfiles checked; 0 errors, 15 warnings.
Rpmlint (debuginfo)
-------------------
Checking: playerctl-debuginfo-2.0.1-7.fc31.x86_64.rpm
playerctl-libs-debuginfo-2.0.1-7.fc31.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.utf8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.utf8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_US.utf8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
playerctl-libs.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-libs.x86_64: W: no-documentation
playerctl-docs.noarch: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-static.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-static.x86_64: W: no-documentation
playerctl-debuginfo.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl.x86_64: W: spelling-error %description -l en_US statusline -> status line, status-line, stateliness
playerctl.x86_64: W: spelling-error %description -l en_US introspectable -> introspect able, introspect-able, introspective
playerctl.x86_64: W: spelling-error %description -l en_US spotify -> spottily
playerctl.x86_64: W: spelling-error %description -l en_US vlc -> vac, VLF
playerctl.x86_64: W: spelling-error %description -l en_US bmp -> mp, bump, imp
playerctl.x86_64: W: spelling-error %description -l en_US cmus -> cums, mus, emus
playerctl.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-devel.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-devel.x86_64: W: no-documentation
playerctl-libs-debuginfo.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
playerctl-debugsource.x86_64: W: invalid-url URL: https://github.com/acrisci/playerctl <urlopen error [Errno -2] Name or service not known>
8 packages and 0 specfiles checked; 0 errors, 17 warnings.
Requires
--------
playerctl-libs (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
playerctl(x86-64)
rtld(GNU_HASH)
playerctl-docs (rpmlib, GLIBC filtered):
playerctl(x86-64)
playerctl-static (rpmlib, GLIBC filtered):
playerctl-devel(x86-64)
playerctl-debuginfo (rpmlib, GLIBC filtered):
playerctl (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libplayerctl.so.2()(64bit)
playerctl-libs(x86-64)
rtld(GNU_HASH)
playerctl-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
libplayerctl.so.2()(64bit)
pkgconfig(gio-2.0)
pkgconfig(gio-unix-2.0)
pkgconfig(gobject-2.0)
playerctl(x86-64)
playerctl-debugsource (rpmlib, GLIBC filtered):
Provides
--------
playerctl-libs:
libplayerctl.so.2()(64bit)
playerctl-libs
playerctl-libs(x86-64)
playerctl-docs:
playerctl-docs
playerctl-static:
playerctl-static
playerctl-static(x86-64)
playerctl-debuginfo:
debuginfo(build-id)
playerctl-debuginfo
playerctl-debuginfo(x86-64)
playerctl:
playerctl
playerctl(x86-64)
playerctl-devel:
pkgconfig(playerctl)
playerctl-devel
playerctl-devel(x86-64)
playerctl-debugsource:
playerctl-debugsource
playerctl-debugsource(x86-64)
Source checksums
----------------
https://github.com/acrisci/playerctl/releases/download/v2.0.1/playerctl-2.0.1.tar.xz :
CHECKSUM(SHA256) this package : c3ae6d74ddd951767da4e7852a76a88a2920ed02f126dab6e3b6f0c77549c74f
CHECKSUM(SHA256) upstream package : c3ae6d74ddd951767da4e7852a76a88a2920ed02f126dab6e3b6f0c77549c74f
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1671571 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
