On lundi 4 mars 2019 00:16:02 CET Neal Gompa wrote: > On Sun, Mar 3, 2019 at 6:14 PM Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> > wrote: > > > > > > Hi, > > > > > > > > I am wondering about the state of the "fedora-review" package. It seems to > > be a pretty important package to ensure new stuff adhers to the latest > > Fedora packaging policy. > > > > > > > > When I ran "fedora-review" I noticed that it was clearly not updated for > > some time: There where outdated points about bundled libraries (nowadays > > without special FPC exception), a warning about an unnecessary "gcc" > > build requirement and many outdated links. > > > > > > > > Well, it turns out fedora-review fails to build from source since July > > 2018 [3] (last successful koji build was in March 2018). I think at > > least some things are fixed upstream [4] but the RPM package was never > > updated.> > > > > > > > > Is fedora-review still the preferred tool to do package reviews? > > > > > > > > > > Background: > > In the last weeks I spent a bit of time checking the review requests for > > hcc [1] and hip [2] which form an important part of AMD's "rocm" stack. > > These packages are "special snowflakes" in a sense that they are > > compilers/compiler wrappers with all the shenanigans this involves > > (bundled llvm, explicit lib dependencies, even dependencies on static > > libraries). > > > > > > > > Approving these libraries would require ignoring quite a few rpmlint > > errors/warnings and I don't feel confident in doing so if the > > fedora-review tool is obviously outdated. > > (Btw: I'd highly appreciate if someone could look at the hcc/hip review > > requests. These packages would enable "open source machine learning" in > > Fedora and IMHO that area fits Fedora's mission pretty well.) > > > > > > > It is still preferred. I was hoping that the in-progress Python 3 > porting PR[1] would land first, but I guess I'll have to push a Git > snapshot release in... > > I don't want to make a new release without Python 3 support. > > [1]: https://pagure.io/FedoraReview/pull-request/312 > I've got a COPR based on the devel branch: https://copr.fedorainfracloud.org/coprs/eclipseo/fedora-review/ _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
