Hi:
Florian Weimer wrote on 2019/02/02 20:37:
* Mamoru TASAKA:
Richard Hughes wrote on 2019/02/02 17:11:
Hi all,
One of my package builds (fwupd) in F30 is failing in the unit tests,
with this failure comparing the expected output of a to_string()
function:
- Size: 1.0 kB
+ Size: 1.0?kB
I assume it's due to the removal of glibc-langpacks-all from the
buildroot. I'ts not immediately obvious from reading
https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot
and https://fedoraproject.org/w/index.php?title=Changes/Remove_glibc-langpacks-all_from_buildroot
what I'm supposed to do. I guess adding back glibc-langpacks-all is
the obvious thing, but I probably only really need en_US.UTF-8 -- I
think. I was surprised C.UTF-8 didn't work. Advice welcome, thanks.
Richard
It may be wrong, however as fwupd-1.2.4 uses g_format_size(), I guess that
this failure is due to recent g_format_size() output change (in glib2-2.59.X):
https://gitlab.gnome.org/GNOME/glib/commit/76af5dabb4a25956a6c41a75c0c7feeee74496da
https://gitlab.gnome.org/GNOME/glib/commit/3aa8b4eba72d0faa57e6bc8727f4f3bab0c2b469
i.e. g_format_size() now returns string like "1.0<nbsp>kB", not "1.0<space>kB".
Do you know what performs the incorrect transliteration here? In
C.UTF-8, <nbsp> can certainly be used, and even in ASCII, <space> is
probably the better transliteration.
Thanks,
Florian
Well, I don't know well.. So what fwupd seems to be doing here is like:
$ echo -e "1.0\xc2\xa0kB" > a.txt
$ echo -e "1.0 kB" > b.txt
$ diff -uNp a.txt b.txt
and my console (gnome-terminal) says:
--- a.txt 2019-02-02 21:03:43.855731848 +0900
+++ b.txt 2019-02-02 21:03:50.462725614 +0900
@@ -1 +1 @@
-1.0 kB
+1.0 kB
So actually it "differs", but it does not show "?" character. (But currently
I tried the above on F-29, not F-30).
Regards,
Mamoru
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
