On Sat, Feb 02, 2019 at 08:57:42AM -0000, Samuel Rakitničan wrote: > With a new version of GCC errors are blocking the build at various places. > Not sure how serious the issue is. Should I just add the compiler flags > to get through the build? Guess the important question is, is the warning correct or not? If it is correct, certainly fix the code, if it is a false positive, either find a workaround, turn the warning off (locally or globally) or don't build wiht -Werror (or turn the particular warning into a warning only, say -Werror -Wno-error=whatever). Warnings do have false positives and with -Werror you need to be prepared to work around the warnings any time new ones appear, typically -Werror is a good fit only for some projects and only for development builds. Jakub _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx