Re: F30 Self-Contained Change proposal: libcrypt.so.1 (compatibility library for POSIX): Let encrypt, encrypt_r, setkey, setkey_r, and fcrypt return ENOSYS instead of performing any real operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Simo Sorce:

>> Maybe the stub implementation should just overwrite the argument with
>> zeros.
>
> I wouldn't overwrite with zeros because then it is clear the encryption
> failed and if it is used in non-orthodox ways could give an attacker a
> way to exploit the zeroing.
>
> (for example if someone uses it to encrypt a password, instead of
> hashing it and then compare to some stored value, then zeroing might be
> a bad choice as all invocations will always return the same value and
> would always compare "right")

That's a fair point.  Overwriting with random data seems better.
(There's precedent for doing that on decryption failures, too.)

Thanks,
Florian
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux