* J. Scheurich [13/01/2019 09:42] :
>
> What can be improvided ?
Hi.
I reviewed your spec file and found a number of chnages that could me made.
* The tags would be more readable if their values were aligned.
* This is the longest description I've ever seen. I would shorten it.
* Some lines are over 75 chars long and should be split over several lines
It seems you modify the only entry in the %changelog when you update the spec
file. I usually start adding entries once I submit spec files to make it
clearer what has changed and when.
My version of your spec file is attached. I've haven't tried to build an rpm
from it so you probably want to test it through mock.
Emmanuel
%global extraver pl1216
Summary: A graphical X3D/VRML97 editor, simple 3D modeler and animation tool
Name: wdune
Version: 0.99
Release: 1.%{extraver}%{?dist}
#Copyright: GPL
License: GPLv3+
URL: http://wdune.ourproject.org/
Source: ftp://ftp.ourproject.org/pub/wdune/wdune-%{version}.tar.bz2
BuildRequires: gcc-c++
BuildRequires: gawk
BuildRequires: make
BuildRequires: bash
BuildRequires: motif-devel
BuildRequires: libXi-devel
BuildRequires: libpng-devel
BuildRequires: libjpeg-devel
BuildRequires: mesa-libGLU-devel
BuildRequires: expat-devel
BuildRequires: flex
BuildRequires: bison
BuildRequires: libusb-devel
BuildRequires: CGAL-devel
BuildRequires: gmp-devel
BuildRequires: libcurl-devel
BuildRequires: ImageMagick
BuildRequires: aqsis-core
BuildRequires: freetype-devel
BuildRequires: bitstream-vera-sans-fonts
BuildRequires: desktop-file-utils
Requires: rcs
Requires: firefox
Requires: kolourpaint
Requires: audacity
Requires: lxterminal
Requires: ImageMagick
Requires: aqsis-core
Requires: bitstream-vera-sans-fonts
%description
The white_dune program is a graphical X3D/VRML97 editor,
simple extrusion/NURBS/Superformula 3D modeler and animation tool.
X3D and VRML97 are the ISO standard for displaying 3D data over the web.
With Cobweb or X3DOM it can displayed in any webgl enabled web browser.
This includes animation, real-time interaction and multimedia (image, movie,
sound).
Dune can read X3DV/VRML97 files, display and let the user change the
scene-graph and all fields of all nodes. The most powerful 3D modeling
features of white_dune support the VRML97 Amendment1 style NURBS nodes
and Superformula based PROTOs.
%prep
%setup -q
%build
%configure --with-optimization \
--without-devil \
--with-vrmlbrowser=firefox \
--with-helpurl="/usr/share/doc/wdune/docs/" \
--with-protobaseurl="/usr/share/doc/wdune/docs" \
--with-checkincommand="ci" \
--with-imageeditor="pinta" \
--with-imageeditor4kids="kolourpaint" \
--with-soundeditor=audacity
%make_build
%install
mkdir -p $RPM_BUILD_ROOT/%{_bindir}
mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/misc/white_dune
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/applications
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/icons/Bluecurve/48x48/apps
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/pixmaps/
install -m 755 -p bin/dune $RPM_BUILD_ROOT/%{_bindir}/dune
install -m 755 -p bin/dune4kids $RPM_BUILD_ROOT/%{_bindir}/dune4kids
install -m 755 -p bin/illegal2vrml $RPM_BUILD_ROOT/%{_bindir}/illegal2vrml
install -m 644 -p desktop/kde/dune.desktop $RPM_BUILD_ROOT/%{_datadir}/applications/dune.desktop
install -m 644 -p desktop/kde/dune.png $RPM_BUILD_ROOT/%{_datadir}/pixmaps/dune.png
install -m 644 -p desktop/kde/dune4kids.desktop $RPM_BUILD_ROOT/%{_datadir}/applications/dune4kids.desktop
install -m 644 -p desktop/kde/dune4kids.png $RPM_BUILD_ROOT/%{_datadir}/pixmaps/dune4kids.png
install -m 644 -p man/dune.1 $RPM_BUILD_ROOT/%{_mandir}/man1/dune.1
install -m 644 -p man/dune4kids.1 $RPM_BUILD_ROOT/%{_mandir}/man1/dune4kids.1
install -m 644 -p man/illegal2vrml.1 $RPM_BUILD_ROOT/%{_mandir}/man1/illegal2vrml.1
desktop-file-install --add-category="Graphics" \
--delete-original \
--dir=%{buildroot}%{_datadir}/applications \
%{buildroot}/%{_datadir}/applications/dune.desktop
%files
%doc README.txt COPYING.txt docs
%{_bindir}/dune
%{_bindir}dune4kids
%{_bindir}/illegal2vrml
%{_datadir}/applications/dune.desktop
%{_datadir}/pixmaps/dune.png
%{_datadir}/applications/dune4kids.desktop
%{_datadir}/pixmaps/dune4kids.png
%{_mandir}/man1/dune.1*
%{_mandir}/man1/dune4kids.1*
%{_mandir}/man1/illegal2vrml.1*
%changelog
* Wed Sep 20 2017 J. Scheurich <mufti11@xxxxxx> 0.99pl765
-- Initial packaging
Release: 1%{?dist}
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
