A few unrelated notes:
- don't mix tabs and spaces
- Apache 2.0s is not a valid license shorthand, use ASL 2.0
- don't capitalize the spec name, use luxcorerender
- Should be Source2 here, not Source3:
install -pm 0644 %{SOURCE2} \
%{buildroot}%{blender_libdir}/scripts/bpydata/config/blendluxcore-
default.cfg
- In %files %{blender_libdir}/scripts/bpydata/config/luxblend-default.cfg
should probably be %{blender_libdir}/scripts/bpydata/config/blendluxcore-
default.cfg
- Use BuildRequires: boost-devel instead of static and add the PYTHON_V=3
variable as a cmake parameter. It will now detect Boost correctly
%cmake \
-DCMAKE_VERBOSE_MAKEFILE:BOOL=TRUE \
-DCMAKE_CXX_FLAGS="$CXXFLAGS -DLUXRAYS_DISABLE_OPENCL=0" \
-DPYTHON_V=3
- %{buildroot}%{bindir} → %{buildroot}%{_bindir}
- The install part seems not to be working, try something like:
install -Dpm 0755 bin/* %{buildroot}%{_bindir}/
install -Dpm 0755 lib/*.{a,so*} %{buildroot}%{_libdir}/
mv %{buildroot}%{_libdir}/pyluxcore.so %{buildroot}%{python3_sitearch}/
install -Dpm 0644 include/* %{buildroot}%{_includedir}/
- there are no luxcorerender.desktop and luxcorerender.svg files
- blendluxcore is rot extracted and installed
- %package lib → %package libs for consistency
- COPYING.txt should be intalled with %license not %doc
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
