Yeah all "gosetup -q" (which is gofed default) are broken because of your commit: 294 # Convenience macro to relay computed arguments to %setup 295 - %forgesetup(a:b:cDn:Tq) %setup %{?forgesetupargs} %{-a} %{-b} %{-c} %{-D} %{-n} %{-T} %{-q} 296 + # Optional parameters: 297 + # -a process all sources in one go, instead of using separate -z calls 298 + # -z <number> read %{?forgesetupargs<number>} 299 + # -v be verbose 300 + %forgesetup(az:v) %{lua: 301 + local fedora = require "fedora.common" 302 + if (rpm.expand("%{-z}") == "") and (rpm.expand("%{-a}") ~= "") then 303 + for _,s in pairs(fedora.getsuffixes("forgesetupargs")) do 304 + print(rpm.expand("%setup %{!-v:-q} %{?forgesetupargs" .. s .. "}\\n")) 305 + end 306 + else 307 + print( rpm.expand("%setup %{!-v:-q} %{?forgesetupargs" .. rpm.expand("%{-z*}") .. "}\\n")) 308 + end 309 + } 310 311 # Convenience macro to relay computed arguments to %autosetup 312 - %forgeautosetup(a:b:cDn:TvNS:p:) %autosetup %{?forgesetupargs} %{-a} %{-b} %{-c} %{-D} %{-n} %{-T} %{-v} %{-N} %{-S} %{-p} 313 + # Parameters relayed to %autosetup: -v -N -S -p 314 + # Optional parameters: 315 + # -z <number> read %{?forgesetupargs<number>} 316 + %forgeautosetup(z:vNS:p:) %{lua: 317 + print(rpm.expand("%autosetup %{-v} %{-N} %{?-S} %{?-p} %{?forgesetupargs" .. rpm.expand("%{-z*}") .. "}\\n")) 318 + } 319 + 320 + # List files matching inclusion globs, excluding files matching exclusion blogs 321 + # Parameters: 322 + # -i "<globs>" include shell globs (also takes all other macro arguments) 323 + # -x "<globs>" exclude shell globs 324 + %listfiles(i:x:) %{expand: 325 + while IFS= read -r -d $'\\n' finc ; do 326 + printf "%s\\n" %{?-x*} \\ 327 + | xargs -i realpath --relative-base=. '{}' \\ 328 + | grep "${finc}" >/dev/null || echo "${finc}" 329 + done <<< $(printf "%s\\n" %{?-i*} %* | xargs -i realpath --relative-base=. '{}' | sort -u) 330 + } Please revert this, we should be able to use whatever flag supported by %setup and %autosetup, not a small subset. How do you even pass the basic -n flags now? With you mods, we have to edit hundreds of specs to remove the -q flags. So much for keeping the API stable. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx