Hi,
On 19-09-18 02:09, Adam Williamson wrote:
On Tue, 2018-09-18 at 17:06 -0700, Adam Williamson wrote:
On Tue, 2018-09-18 at 18:57 -0400, Randy Barlow wrote:
On 9/18/18 3:23 PM, Chris Murphy wrote:
But is this bugginess worth a FE to try and get -58 onto the Beta?
Lots of users will install the Beta and will not want to reinstall.
Seems like suboptimal behavior.
I think it's worth a FE since this was one of the Fedora 29 changes. I
think it'd be ideal to be able to test all 29 changes in the beta.
Then can someone propose it, like, now? Cos I'm working on the Beta RC4
request right now...
Note, -58 includes a somewhat-significant patch which was not mentioned
in the package changelog:
https://src.fedoraproject.org/rpms/grub2/blob/master/f/0240-Attempt-to-fix-up-all-the-places-Wsign-compare-error.patch
on the one hand, I suppose that could plausibly be what fixes this; on
the other hand, it is Change, and I don't like change on blocker week
Tuesdays...
Hans, did you test whether just running the grub2-mkinstall *without*
updating grub2 at all 'fixed' the bug?
No I did not test that. I was surprised that the bug existed at all.
Note my vm was based on a significantly older compose, so it had
grub2-2.02-51, so the dnf update + grub2-mkinstall took it all the
way from -51 to -58.
Cos now I'm suspicious about
exactly how this -58 magically fixed this.
I'm afraid I've no clue how -58 fixes this, I was surprised that I
could reproduce the bug in the first place.
Regards,
Hans
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
