Hi, On Tue, Sep 4, 2018 at 4:00 PM Owen Taylor <otaylor@xxxxxxxxxx> wrote: > Each flatpak needs to be tagged into two koji tags: > > f29-modular-updates (this is the destination for the module build) > f29-flatpak (this is the destination for the Flatpak container build) > > The package list for each koji tag is populated from pagure by the > owner-sync-pagure script (*). But that script has no way of knowing > what repositories under modules/ in src.fedoraproject.org are just > modules and what modules are also Flatpaks, so it has no way to > populate the f29-flatpak tag package list correctly. I haven't dealt with modularity yet, really, so tell me if i wrong (i'm kind of guessing a little bit from briefly snooping around). module building is like so, right? 1) user runs `fedpkg module-build` in a the module git repo 2) this gets submitted to a service to build the module 3) the service reads a metadata file with a list of rpms to build 4) the service submits those builds to koji 5) sometime later owner-sync-koji runs and does a massive loop over all modules and finds all packages associated with each module and tags them all with f29-modular-updates so assuming i have the gist of things captured above, my question is…why doesn't the service that submits the builds, also do the tagging ? it just seems strange to have the huge loop doing extra work. if the service did the tagging, then it could also do the flatpak detecting, and do the additional tagging. judging from the koji command line, it seems koji even allows tagging multiple builds at the same time, so i guess the build service could do them all in one swoop. Anyway, take my suggestions with a grain of salt because i have an incomplete understanding of the architecture, MBS, koji, etc. --Ray _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx