Dne 25.7.2018 v 13:53 Zbigniew Jędrzejewski-Szmek napsal(a): > On Wed, Jul 25, 2018 at 01:48:58PM +0200, Vít Ondruch wrote: >> >> Dne 24.7.2018 v 22:24 Gerald B. Cox napsal(a): >>> On Tue, Jul 24, 2018 at 10:07 AM, Artur Iwicki <suve@xxxxxxxxxxxxxxxxx >>> <mailto:suve@xxxxxxxxxxxxxxxxx>> wrote: >>> >>> That section of the guide is a bit poorly worded. You should *not* >>> use "git add" on source tarballs. These should be added only via >>> means of "fedpkg new-sources $FILES; git add ./sources". >>> >> "new-sources" should not be mentioned in basic documentation. These >> should be added via means of "fedpkg import package.srpm". >> >> The workflow for updated package: >> >> ~~~ >> $ git add -u >> $ fedpkg clog >> $ git commit -F clog >> $ fedpkg import updated.srpm >> $ git commit --am >> ~~~ > Why make two separate commits here? If I am not mistaken, you cannot import if your git repository is not in clean state, so you would have to reset the repository. Also, the files in the repository are in state I want to commit, but the SRPM might be a bit obsolete, typically due to last second changes of changelog. So the "commit" and later "commit --amend" is safe workflow IMO. V. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/AGR5USBTRESN5ALPISROUUBDUAPPCHLQ/
