On Thu, Jun 28, 2018 at 2:06 PM Antonio Trande <anto.trande@xxxxxxxxx> wrote:
> Does anyone know how to fix 'antimony'?
> https://bugzilla.redhat.com/show_bug.cgi?id=1594496
The code has 2 problems. One is simply a missing "const" keyword,
easy to fix. The other problem is that the Qt authors apparently
thought it was a good idea to make a common word, "slots", be a macro.
Since there is a structure element in the python headers with the name
slots, bad things happen. Try the attached patch. It is slightly
horrible, but should fix the build. And please slap any developer
near you who tries to #define a short word like that.
(I recently had to help a bunch of upstreams cope with the #define
iszero that the latest revision of the C standard required to be added
to math.h. Guess what? People had already used "iszero" as a
function or method name, many times, and not synonymously with the
meaning of the C standard macro, either.)
--
Jerry James
http://www.jamezone.org/
--- app/viewport/render/instance.h.orig 2016-11-27 19:16:48.000000000 -0700
+++ app/viewport/render/instance.h 2018-06-28 14:44:06.985669560 -0600
@@ -1,6 +1,8 @@
#pragma once
+#undef slots
#include <Python.h>
+#define slots Q_SLOTS
#include <QObject>
#include "viewport/image.h"
--- lib/graph/src/util.cpp.orig 2016-11-27 19:16:48.000000000 -0700
+++ lib/graph/src/util.cpp 2018-06-28 14:19:57.332549621 -0600
@@ -47,7 +47,7 @@ std::pair<std::string, int> getPyError()
error_traceback = "";
for (int i=0; i < PyList_Size(lst); ++i)
{
- char* c = PyUnicode_AsUTF8(PyList_GetItem(lst, i));
+ const char* c = PyUnicode_AsUTF8(PyList_GetItem(lst, i));
assert(!PyErr_Occurred());
error_traceback += std::string(c);
}
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/WFFFBMSKMU27FSHJLAKQJZMRJ5VGVPGK/
