Hi,
On 01-06-18 22:29, Peter Jones wrote:
On Thu, May 31, 2018 at 12:14:57PM -0500, Chris Adams wrote:
Once upon a time, Jason L Tibbitts III <tibbs@xxxxxxxxxxx> said:
If we're going to patch grub to expand the set of keys it will watch
for, is it possible to just expand the set to encompass all keys? We
don't really need to make it that hard to find the grub menu, do we?
To add: printing a message to the screen for only a few seconds can be
almost useless, as many times monitors take those same seconds to sync
to the output of the GRUB screen (it seems to always be in a different
mode from the BIOS/UEFI boot screen).
One of the outcomes of the work Hans has done and coordinated so far is
that on most UEFI machines, we should be able to switch from the
graphics the firmware has presented to our own content without a
re-sync.
So IMHO, taking any key would be good because not only do I not have
to remember a specific one or few keys, I don't have to read a message
that is only actually visible for 0.2 seconds.
Currently the code accepts any key the firmware supports to stop the
countdown. That pretty much means:
- On most EFI machines we don't detect modifiers that aren't modifying
anything: ctrl-a works but ctrl doesn't. Strictly speaking some
machines could support this, but we don't have code right now to do
it[0].
- Intel-based Mac machines are like the above, but also Ctrl doesn't
work at all and will mask us from seeing the other key being pressed.
This is because they don't implement the protocol to get key state at
all.
- If you're on a serial console, F keys don't work (but also they're bad
choices to use anyway, because firmware likes to use them a lot.)
- In general everything else should work.
[0] Maybe something like this; the machine in front of me right now
doesn't support it. Someone let me know if it works:
https://pjones.fedorapeople.org/0001-EFI-console-getkey-Fix-shift-ctrl-alt-when-pressed-a.patch
So this does not work as is, because grub expects grub_getkey()
to return e.g. an ascii 'A' for things like SHIFT + A not
"A" + the shift mod bit.
But it did point me in the right direction to add getkeystatus
(which returns modifiers) support to the EFI console code,
this is a bit tricky but it works.
With this in place I can now make the GRUN menu show when
hidden on EFI machines by simply keeping SHIFT held down
during boot, which is quite nice.
I'm going to submit a pull-req to you with various patches
related to the grub work which I've been doing, including
the patches for adding getkeystatus to the EFI console code.
Regards,
Hans
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/2JPIXXXNO7VHZTNFYY7SPF6TWWEN2N37/
