On jeudi 8 mars 2018 16:37:57 CET Jan Chaloupka wrote: > On 03/07/2018 04:07 PM, Jan Chaloupka wrote: > > > > Saying that, I will prepare new builds of gofed so the new spec files > > are generated with the new macros. > > > F27 gofed build: > https://bodhi.fedoraproject.org/updates/FEDORA-2018-52f059bf00 > F28 gofed build: > https://bodhi.fedoraproject.org/updates/FEDORA-2018-13edd2e62f > Can I suggest a few thing? - Add a switch to disable the tests like before. I use bcond_without: # Run tests in check section %bcond_without check %if %{with check} BuildRequires: golang(github.com/stretchr/testify/assert) BuildRequires: golang(github.com/bmizerany/assert) %endif %if %{with check} %check %gochecks %endif - Try to grab the packager name from Git like they do in rust2rpm: def detect_packager(): rpmdev_packager = shutil.which("rpmdev-packager") if rpmdev_packager is not None: return subprocess.check_output(rpmdev_packager, universal_newlines=True).strip() git = shutil.which("git") if git is not None: name = subprocess.check_output([git, "config", "user.name"], universal_newlines=True).strip() email = subprocess.check_output([git, "config", "user.email"], universal_newlines=True).strip() return "{} <{}>".format(name, email) return None - why does it needs sudo to run sometimes? - This is not needed anymore, even on EPEL7: #define license tag if not already defined %{!?_licensedir:%global license %doc} - would it be possible to check the dependencies on https:// src.fedoraproject.org/ instead of pkgdb which is outdated. - would it be possible to detect if a repo has a tagged release and use it instead of a commit if it's detected Best regards, Robert-André _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
