Dne 2.3.2018 v 16:13 Kalev Lember napsal(a): > On 03/02/2018 03:59 PM, Dennis Gilmore wrote: >> El vie, 02-03-2018 a las 11:28 +0100, Kalev Lember escribió: >>> Hi, >>> >>> hughsie just did a new appstream-data compose for F29 and I noticed >>> there's quite a large number of packages failing in the logs: >>> >>> https://dl.fedoraproject.org/pub/alt/screenshots/f29/failed.html >>> >>> Would be awesome if maintainers could have a look and see if they can >>> make their packages pass! >>> >> We were supposed to make builds fail if the appstream metadata failed, >> why has that not been done? > Sorry, I dropped the ball on this. I believe we need a brp script for > rpmbuild that runs: > > DESTDIR=%{buildroot} appstream-util check-root > > and errors out if it fails. > > AppData packaging guidelines [1] requires every package to run "appstream-util validate-relax". Does this check fail when the icon has not valid size? Of course moving this into BRP script would be probably better ... Vít [1] https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate%20usage _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
