-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 02/28/2018 01:38 PM, Daniel P. Berrangé wrote: > On Wed, Feb 28, 2018 at 01:12:03PM -0500, Matthew Miller wrote: >> On Wed, Feb 28, 2018 at 05:57:53PM +0000, Daniel P. Berrangé wrote: >>> mistake that caused files to go missing, and was never detected by the person >>> making the change, because of the use of globs. So I agree it is good practice >>> to explicitly list files without globs whereever it is practical todo so. I'd >>> make an exception for files which don't have functional impact eg don't list >>> 1000 HTML files individually, but it is always worth listing everything in >>> /usr/bin, and /usr/lib(64) explicitly without globs. >> >> I used to agree with this, but I've come around to thinking that spec >> files should be smaller, less complicated, and more automatable. I >> think we'd be better having a post-build test warning that this package >> has files missing from the previous build. That could be advisory, or >> it could even gate, with the packager clearing the gate by updating the >> file list in the test, rather than in the spec file. > > The further down the workflow a problem is detected the more time expensive > / disruptive it is to fix it. So while having post-build tests to validate > lots of things is great (and I wish we had more of it in Fedora), I see it > as complementary to anything that we can do to detect problems earlier. I > rather see failures right away when I test the new RPM build locally, than > waiting to push it through koji and wait again for post-build tests to find > the problem, as by that time I've context switched my mind away to a > different bit of work. Agree with this. We need to have something that is automated and also happens as soon as possible. Gating rawhide should give us the ability to do something like this and enforce it (i.e. making sure rebuilt dependent packages get pushed along with the package that introduced the soname bump). I know this isn't clearly black and white (i.e. oftentimes it's more than just a rebuild, and requires code changes) but should give us a good start. Dusty -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPb6zG5c6sV89tRYPMwLb1zlS5nEFAlqXTJsACgkQMwLb1zlS 5nFCUBAAuh+tHA9yIm6W8Ge4KMLahDzypb64/pXFZ4FkOcQf0TO6KpAhzXtvI+jj /zLdZqOsfttjtSCYdOTSrjaTg9HX7g1v8r3KnpmqX1OKMDF83kZc+RiUHULnuCPR OUv8yQ3fFc+yTlSeW3UScJ+xbnZnB/pZp9TFilDC7Ny33qs7pnzzp71QgguIUtp2 XlQm07aY7iZz0JqajQRnXWAhRJGYVPA9MR29SXU9a7LJ0HMrBpgRCQruiCaWozpz LclhVV9sMGVeKs5yuxroI1t2DSBkjrl6umlvklMEtx22SpKFo8xWNoAScEWR8zXY W1F2dY5Kxdv6Y4N1ACj3g/m+xziTqsy/acnDkqoK7Afpj51J0poZnIuwKk/SReft a3nPJSSMrowxMn9+ZZVpuonvK0L3D+ACmJkPSI6arCmPWaXJqcBn2IcRUOV5Ok49 VL6Kl6AP7UdDQkW06T5Ub1wjjK4yjRiWVoNxrqp0y24wFzMi/NVUwelZlKbs6jjR AbPE9ucNnYWrqqAQMHXjPC7Q+I64sfdkUmVadLqp3mAz0VToeRsJEdhq6ZMyk65h eYz4prhfAL7mbxmAhQNdOnihALcftOE9MOxOGL3MF3Il5WQAGkqqXwbVUW9Ryg40 NqoVzQtQjGif2O3oRFFKlR5vLpvntzOkISB+gQV/lIs1bhYKW8I= =1cnG -----END PGP SIGNATURE----- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
