So basically, koji has a list of macros (hardcoded in koji/__init__.py)
which unfortunately carries the comment:
#XXX - this needs to be configurable
Those get turned into config_opts['macros']['%_foo']['whatever']
directives in the generated mock config.
Some of those macros (%vendor, %packager, %distribution) are pulled from
the koji configuration file. There is also some other specialized code for these
three. Koji will search the specfile for any definitions of them and
fail to start the build if they're found, and there's other code which
will bomb out if the buildsystem somehow didn't set the proper values in
the generated packages.
What behavior would we want here? Is it appropriate to allow packagers
to override BugURL:? If so then it should be OK to just add the bit of
code to grab it from the config options and to add one macro to the
definition in koji/__init__.py. I have verified that passing the bugurl
on the rpm command line works as expected, with the specfile overriding
if the tag is present. I've also verified that passing it through mock
via config_opts works as expected. Of course I don't have my own koji
setup to actually use to test things that way.
Anyway, it's not much work for someone who knows what they're doing;
more work for me (because I never know what I'm doing) but I can still
whip something up. I can't think of any reasonable reason that upstream
would reject this as long as it comes with test code, but there are 56
open pull requests so....
- J<
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
