On 02/14/2018 05:28 PM, Petr Šplíchal wrote:
Hi! During the last days there have been concerns raised regarding what is an appropriate content for the tests namespace. [1] My original idea was to enable sharing tests even across branches of the same component, not only for tests to be used by completely different packages. The initial examples might have been a bit misleading in this respect. One of the main points still holds:* Tests might follow a different branching pattern than the dist-git repo, leading to code duplicationFrom the feedback from developers I feel they always keep on mind and care a lot about the maintenance costs. So it perfectly makes sense to me if they want to keep and maintain tests in a separate repo instead of merging/cherry-picking between dist-git branches.
+1
From my PoV, it makes perfect sense to share tests between branches, or
between different versions of packages available in modules streams (soon). Honza
When, for a particular package, it is the most efficient way to maintain tests in a separate repo why should we discourage from this approach? There are packages where it makes more sense to store test code directly in dist-git. And it is still an option. But why should we enforce this for all? Please share your thoughts and real-life examples. For those who are not familiar with the topic there is a new wiki page with a summary of the Share Test Code approach [2]. psss... [1] https://pagure.io/fedora-infrastructure/issue/6695 [2] https://fedoraproject.org/wiki/CI/Share_Test_Code On 7 December 2017 at 10:38, Petr Splichal <psplicha@xxxxxxxxxx> wrote:Hi! While working on adding CI tests [0] using the Standard Test Interface a need arose to have a shared git repository where tests could be stored: * A large number of test files makes a dist-git repository more difficult to maintain * Tests might follow a different branching pattern than the dist-git repo, leading to code duplication * Shared maintenance for tests sometimes benefits from different access levels than the release dist-git repository The plan is to create a new “tests” namespace in Fedora git/pagure dedicated to storing the shared test code. To enable execution of these tests by the CI pipeline, tests.yml file in dist-git will be used to link the tests in the standard way as defined by the Standard Test Interface [1]. This approach should help to efficiently maintain tests & minimize test code duplication. Using a dedicated git repo for test code also means to keep dist-git more as a place for storing metadata only: Build metadata (spec file = how to build the package) and test metadata (tests.yml = how to test the package) rather than mixing spec files with test code itself. Please note that this does not mean that all tests should now go into this new namespace. You can still link tests directly from upstream (like GitHub) or any other source. Also, for unit tests it makes more sense to be kept directly with the project source and executed there. Shared tests namespace in Fedora will be suitable especially for functional and integration testing which should help to continuously ensure the OS works as a whole. For more detailed motivation and real-life examples see the Share Test Code proposal on the Fedora CI list [2]. If you have any questions or comments feel free to share them here or in the pagure issue requesting the new namespace: https://pagure.io/fedora-infrastructure/issue/6478 Thanks. psss... [0] https://fedoraproject.org/wiki/CI [1] https://fedoraproject.org/wiki/Changes/InvokingTests [2] https://lists.fedoraproject.org/archives/list/ci@xxxxxxxxxxxxxxxxxxxxxxx/thread/55U6V6UHA54MJLD2F6JF46EOLMVRUAE7/
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
