On Thu, Feb 8, 2018 at 9:09 PM, Miroslav Suchý <msuchy@xxxxxxxxxx> wrote:
> Hi,
> I am sometimes reviewing spec files and I very often see common mistakes. I mean in packages which are already in
> Fedora. For a long time and they have some dust from past times.
>
> I am not going to file bug reports as those are not bugs. I will just point it here and leave it up to you to check your
> spec files:
>
> * Group: System Environment/Base
>
> Please remove it. Group was intended for something (sort apps in menus), but it never actually worked. It was required
> for EL5 packages. Since EL6 it can be omitted. And nowadays it is recommended to remove it completely.
>
>
> * rm -rf $RPM_BUILD_ROOT
>
> In the past, it was necessary to clean the buildroot at the beginning of %install and the end of %clean. This is no
> longer true and not needed since F12.
Not needed in EL6 as well?
>
> * %defattr(-,root,root,-)
>
> If you have this at the top of your %files section, then you can safely remove it. This is default since rpm 4.2, so it
> is not needed even for RHEL5.
>
> * Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>
> RPM define builroot variable since F12 (and EL6). There is no need to define it yourself.
>
> Miroslav
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
--
Regards,
Chenxiong Qi
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
