On 02/08/2018 04:53 PM, Neal Gompa wrote:
On Thu, Feb 8, 2018 at 9:49 AM, Brett Lentz <blentz@xxxxxxxxxx> wrote:
On 08/02/18 14:09 +0100, Miroslav Suchý wrote:
* rm -rf $RPM_BUILD_ROOT
rpmdev-newspec still inserts this. It may be worthwhile to file a bug to get
it to stop.
The only reason I haven't dropped it yet is because SLE 11 still is
supported, and it requires it.
Does it, really? IIRC Suse started doing this long long before we did -
we basically copied it from them:
%__spec_install_pre %{___build_pre}\
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf "${RPM_BUILD_ROOT}"\
mkdir -p `dirname "$RPM_BUILD_ROOT"`\
mkdir "$RPM_BUILD_ROOT"\
%{nil}
I could see into adding some magic into removing it when newer rpm is
detected, but I'm not sure it's worth it for a single line.
That single line is not just entirely harmless junk, it inserts an
insecurity into the picture which the above _install_pre snippet fixes,
and adding sections that might not even be needed can have other
unwanted side-effects, witness
https://bugzilla.redhat.com/show_bug.cgi?id=1542743 where a package
actually fails to build because there's a bogus/redundant %install
section containing that one line.
So please, remove it. If SLE 11 really requires it then handle it that
old dog specially. It is worth it.
- Panu -
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
