Re: Clean up your spec files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8 February 2018 at 15:39, Kamil Dudka <kdudka@xxxxxxxxxx> wrote:
[..] 
For example logrotate upstream maintains a spec file that is regularly updated
and CI-tested by Travis:

https://github.com/logrotate/logrotate/commits/master/logrotate.spec.in

OK. Please compare what is one that URL with https://src.fedoraproject.org/rpms/logrotate/raw/master/f/logrotate.spec
Just try to use command like:

$ diff -u <(curl -s https://src.fedoraproject.org/rpms/logrotate/raw/master/f/logrotate.spec) <(curl -s https://raw.githubusercontent.com/logrotate/logrotate/master/logrotate.spec.in) | less

Additionally to compare this spec.in with spec used in SuSE, altlinux and few other ..

Spec files of csdiff, cscppc, csmock, and cswrap are produced by make-srpm.sh
maintained in the upstream git repositories.

In such cases you will be manually adding %changelog.
In all those cases we are talking about so simple packages that one time written correctly spec file can be used for years.
Looks like someone who found idea make-srpm.sh scripts didn't know that if in source tar ball will be included <package>.spec it will be possible to build such package by

$ rpmbuild -ta <package>.tar.gz

In other words instead including such script should be included spec generated on "make dist-check" when tar ball with new version will be created by maintainer.
Nevertheless logrote and other packages which you've mentioned by you already have own history of changes in Fedora and have as well higher release numbers (all of them).

It will be really better if source tree maintainers will be only focused on maintaining such tree and will leave packaging to the people who are maintaining packages in different OSes (what about *BSD, Solaris/OpenIdiana?) and OSes distributions (what about Debian, OpenWRT/Lede .. ?).
Usually effort like in examples which you gave are pure waste of time because maintaining packages it is not the same as maintaining source tree of exact package.
On both areas is required quite different knowledge.

kloczek
-- 
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH

 

Kamil

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux