Re: Packaging wiki: shortcoming in Github Source0 (?)

Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> · Thu, 1 Feb 2018 20:47:19 -0800



    Quick hint I have learned and here is
      the example for COPR Scribus spec file:

      
https://github.com/%{name}project/%{name}/archive/master.tar.gz#/%{name}-%{version}-%{build_timestamp}git.tar.gz

      
      Note the hash tag meant to rename the package.

      
      Luya

      
      On 2018-02-01 03:42 PM, Germano Massullo wrote:

    
      I think I have found a shortcoming in

      https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision

      Github line, which is

      Source0:
      https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz

      but I am not sure, so I have not made any edit to the wiki page.

      
      In my case I am packaging bettercap-ng with the following
      attributes

      commit eb1a53efa3171aefed0ec9766d8c5047bd0df289

      shortcommit eb1a53e 

      
      rpmbuild parser will translate Source0 into

      https://github.com/evilsocket/bettercap-ng/archive/eb1a53efa3171aefed0ec9766d8c5047bd0df289/bettercap-ng-eb1a53e.tar.gz

      but if you try inserting such URL in your browser, Github will
      return a file named

      
      bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289.tar.gz
      instead of
      bettercap-ng-eb1a53e.tar.gz
      so if you run locally
      $ rpmbuild -bs rpmbuild/SPECS/bettercap.spec
      you will obviously get
      error: File /home/user/rpmbuild/SOURCES/bettercap-ng-eb1a53e.tar.gz: No such file or directory.
      

      Therefore I think wiki line
      Source0:  https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
      should be changed into
      Source0:  https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz
      

      Am I right?
      Best regards

      
      _______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx

    
    -- 
Luya Tshimbalanga
Graphic & Web Designer
E: luya@xxxxxxxxxxxxxxxxx
W: http://www.coolest-storm.net

  
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx