On vendredi 2 février 2018 00:42:07 CET Germano Massullo wrote: > I think I have found a shortcoming in > https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision > Github line, which is > Source0: > https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{shortcommit}.ta > r.gz but I am not sure, so I have not made any edit to the wiki page. > > In my case I am packaging bettercap-ng with the following attributes > commit eb1a53efa3171aefed0ec9766d8c5047bd0df289 > shortcommit eb1a53e > > rpmbuild parser will translate Source0 into > https://github.com/evilsocket/bettercap-ng/archive/eb1a53efa3171aefed0ec9766 > d8c5047bd0df289/bettercap-ng-eb1a53e.tar.gz but if you try inserting such > URL in your browser, Github will return a file named > > bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289.tar.gz > > instead of > > bettercap-ng-eb1a53e.tar.gz > > so if you run locally > > $ rpmbuild -bs rpmbuild/SPECS/bettercap.spec > > you will obviously get > > error: File /home/user/rpmbuild/SOURCES/bettercap-ng-eb1a53e.tar.gz: No > such file or directory. > > Therefore I think wiki line > > Source0: > https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{shortcommit}.ta > r.gz > > should be changed into > > Source0: > https://github.com/OWNER/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz > > Am I right? > > Best regards It seems specific to your package. I nave no issue with %{url}/archive/% {commit}/%{name}-%{shortcommit}.tar.gz I've just tested with a random Golang package: Getting https://github.com/zyedidia/poller/archive/ ab09682913b79f402713d1df1977dedc19eb25ac/poller-ab09682.tar.gz to ./poller- ab09682.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 157 0 157 0 0 26 0 --:--:-- 0:00:06 --:--:-- 34 100 15912 0 15912 0 0 2652 0 --:--:-- 0:00:06 --:--:-- 137k No issue. Best regards, Robert-André _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
