On Tue, 2018-01-23 at 14:16 -0500, Matthew Miller wrote: > On Tue, Jan 23, 2018 at 12:25:56PM -0600, Rex Dieter wrote: > > > There are three tests that must pass in order for updates to go to stable: > > > 0. dist.depcheck - to make sure the update's dependencies are available. > > > 1. dist.abicheck - to make sure the update's ABI remains stable in a > > > given Fedora release. > > > > ... > > > Finally, if it turns out you need to push an update through despite of the > > > test results, you can do so using waiver-cli (dnf install waiverdb-cli). > > > We are working on integrating this into Bodhi itself, making this easier. > > > > I think it unwise to make item 1 a mandatory item at this point. I'd argue > > a large number of packages do not provide public api/abi that's worth > > worrying about in this regard. > > I think we should definine a set of packages where we care about this, > and enable it on a case-by-case basis and make it advisory otherwise. I think we could probably do something a *bit* less icky than a completely manual package list. What I thought of as a very simple initial heuristic would be to only care about changes in "any shared object installed to /usr/lib or /usr/lib64", optionally we could restrict that further to "in a critpath package". That's installed *directly to those directories*, not to any subdirectories of them. This would certainly be less than the set of things we *should* care about, because there are various mechanisms by which a shared object that's not directly in %{libdir} can have a public ABI of some kind (ldconfig snippets, etc). But it would at least be something to start with...unless I'm missing something. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx