On 20 January 2018 at 07:23, Johannes Lips <johannes.lips@xxxxxxxxx> wrote:
Well, of course, but the issue is not the change itself or anything. It's just the implementation and the lack of information for the maintainer.
The maintainer just sees a git commit without additional information other than the scriplets are obsolete, which is not a lot to be honest. I would have preferred a heads-up, especially since it's nothing urgent.
Agree with you.
This why I've proposed in the ticket %changelog entry :)
Proposed %changelog entry note:
"- remove executing gtk-update-icon-cache in %post/%postu/%postrans to update hicolor
theme cache as it is no longer needed (https://pagure.io/packaging-committee/issue/736)"
(just found that in the ticket was repeating word so above is clean version of such entry)
IMO next time on any mass updates part of the approval procedure should be review %changelog entry before start changing first spec.
All to make sure that whoever will feel surprised will be able to go to some URL to read longer explanation (wiki page or at least ticket URL).
kloczek
--
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
