Can we remove the gtk-update-icon-cache entries from our packages now, manually, in advance of the mass update?
On Wednesday, January 3, 2018 11:10 AM, Charalampos Stratakis <cstratak@xxxxxxxxxx> wrote:
----- Original Message -----
> From: "Tomasz Kłoczko" <kloczko.tomasz@xxxxxxxxx>
> To: "Development discussions related to Fedora" <devel@xxxxxxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, January 3, 2018 4:53:24 PM
> Subject: [Proposal] Mass change: remove executing gtk-update-icon-cache in %post/%postu/%postrans to update hicolor
> theme cache
>
> Hi,
>
> I'm trying to follow procedure described on
> https://fedoraproject.org/wiki/Mass_package_changes
>
> Description of the current state
> =======================
>
> At the moment more than many spec files have %post/%postu/%postrans
> scriptles in which is done updating hicolor theme cache by calling:
>
> gtk-update-icon-cache -f %{_datadir}/icons/hicolor
>
> All those scriptles are no longer needed because in hicolor-icon-theme
> package has file triggers updating theme cache on any change in single
> dnf/rpm transaction.
>
> $ rpm -q --filetriggers hicolor-icon-theme
> transfiletriggerin scriptlet (using /bin/sh) -- /usr/share/icons/hicolor
> gtk-update-icon-cache --force /usr/share/icons/hicolor &>/dev/null || :
> transfiletriggerpostun scriptlet (using /bin/sh) -- /usr/share/icons/hicolor
> gtk-update-icon-cache --force /usr/share/icons/hicolor &>/dev/null || :
>
> Remove all those %post/%postu/%postrans scriptles will speedup install
> and upgrades as only one time gtk-update-icon-cache will be executed
> as hicolor-icon-theme transaction action.
>
> List of affected packages
> ===================
> On the list is more than 1300 packages.
> List has been generated in directory with all spec files extracted
> from git repos using command:
>
> $ grep 'gtk-update-icon-cache.*hicolor' * | grep -v hicolor-icon-theme
> | awk -F\. '{print $1}' | uniq > gtk-update-icon-cache_hicolor.lst
>
> gtk-update-icon-cache_hicolor.lst has been added as the attachment in
> this email.
>
>
> If it will be no more comments about this proposal I'll try in a week
> follow next steps of the procedure described on Fedora wiki sending
> final proposal to devel-announce list and after this raise ticket in
> BTS.
>
> PS. Please advise how to implement change without raising +1300
> tickets on bugzilla (I'm not going to sped weeks or months on
> introduce such simple change)
>
> kloczek
> --
> Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH
>
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
>
Hi.
You might want to take a look at https://pagure.io/python-fixrequires which is from a python-SIG member, and modify it for your usecase.
It basically forks a repo, makes the changes to the SPEC, pushes it to your fork and creates a PR to the original repo.
--
Regards,
Charalampos Stratakis
Software Engineer
Python Maintenance Team, Red Hat
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> From: "Tomasz Kłoczko" <kloczko.tomasz@xxxxxxxxx>
> To: "Development discussions related to Fedora" <devel@xxxxxxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, January 3, 2018 4:53:24 PM
> Subject: [Proposal] Mass change: remove executing gtk-update-icon-cache in %post/%postu/%postrans to update hicolor
> theme cache
>
> Hi,
>
> I'm trying to follow procedure described on
> https://fedoraproject.org/wiki/Mass_package_changes
>
> Description of the current state
> =======================
>
> At the moment more than many spec files have %post/%postu/%postrans
> scriptles in which is done updating hicolor theme cache by calling:
>
> gtk-update-icon-cache -f %{_datadir}/icons/hicolor
>
> All those scriptles are no longer needed because in hicolor-icon-theme
> package has file triggers updating theme cache on any change in single
> dnf/rpm transaction.
>
> $ rpm -q --filetriggers hicolor-icon-theme
> transfiletriggerin scriptlet (using /bin/sh) -- /usr/share/icons/hicolor
> gtk-update-icon-cache --force /usr/share/icons/hicolor &>/dev/null || :
> transfiletriggerpostun scriptlet (using /bin/sh) -- /usr/share/icons/hicolor
> gtk-update-icon-cache --force /usr/share/icons/hicolor &>/dev/null || :
>
> Remove all those %post/%postu/%postrans scriptles will speedup install
> and upgrades as only one time gtk-update-icon-cache will be executed
> as hicolor-icon-theme transaction action.
>
> List of affected packages
> ===================
> On the list is more than 1300 packages.
> List has been generated in directory with all spec files extracted
> from git repos using command:
>
> $ grep 'gtk-update-icon-cache.*hicolor' * | grep -v hicolor-icon-theme
> | awk -F\. '{print $1}' | uniq > gtk-update-icon-cache_hicolor.lst
>
> gtk-update-icon-cache_hicolor.lst has been added as the attachment in
> this email.
>
>
> If it will be no more comments about this proposal I'll try in a week
> follow next steps of the procedure described on Fedora wiki sending
> final proposal to devel-announce list and after this raise ticket in
> BTS.
>
> PS. Please advise how to implement change without raising +1300
> tickets on bugzilla (I'm not going to sped weeks or months on
> introduce such simple change)
>
> kloczek
> --
> Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH
>
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
>
Hi.
You might want to take a look at https://pagure.io/python-fixrequires which is from a python-SIG member, and modify it for your usecase.
It basically forks a repo, makes the changes to the SPEC, pushes it to your fork and creates a PR to the original repo.
--
Regards,
Charalampos Stratakis
Software Engineer
Python Maintenance Team, Red Hat
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
