On 08/12/2017 04:00 PM, Zbigniew Jędrzejewski-Szmek wrote:
> On Sat, Aug 12, 2017 at 03:28:15PM +0200, Florian Weimer wrote:
>> On 08/12/2017 03:22 PM, Richard Shaw wrote:
>>> During one of the releng rebuilds my package OCE is failing to build[1]
>>> because it can't find /usr/include/xlocale.h
>>
>>> Was this intentional?
>>
>> Yes, it used to be installed by accident. The header itself clearly
>> said that it was an internal-only header.
>>
>> We removed it without a deprecation warning because most programs had
>> configure checks for <xlocale.h> which started to fail after removal,
>> skipping the #include.
>
> Heh, I just fixed two ftbfs packages with xlocale.h includes, and a bunch
> more back when glibc 2.25 came out, incl. systemd. From what I've seen,
> people don't test for xlocale.h because it's "part of glibc, so always there" ;)
It's not there if you don't use glibc.
Anyway, I was really surprised to learn that systemd sprouted an
#include <xlocale.h>. Looks like that it was introduced in this commit:
commit 11c3a36649e5e5e77db499c92f3cdcbd619efd3a
Author: Thomas Hindoe Paaboel Andersen <phomes@xxxxxxxxx>
Date: Mon Nov 30 21:43:37 2015 +0100
basic: include only what we use
This is a cleaned up result of running iwyu but without forward
declarations on src/basic.
iwyu (“include what you use”,
<https://github.com/include-what-you-use/include-what-you-use>)
apparently produced misleading/incorrect results in this case. That's
annoying. I wonder if we can do anything about it. It doesn't look like
it can automatically ignore bits/ headers in its edits. 8-(
Thanks,
Florian
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
