On Fri, 17 Mar 2017 15:40:34 +0100, Tomasz Kłoczko wrote: > (Resending below as looks like I've replied only to Jan) also resending On Fri, 17 Mar 2017 06:18:56 +0100, Tomasz Kłoczko wrote: > I saw already such tweaks in many Fedora specs %check sections. > IMO such %ifing inside or around %check is incorrect/not needed and can be > removed. > Why? Because: > - all possible to use package tests should be by default enabled > - if rpm packager want to speedup generate binary packages avoiding > execution of %check section it is already possible to do this without spec > file %ifing by use *--nocheck* rpmbuild option. It is really not so simple. :-) Running GDB testsuite in Koji was crashing the build hosts as they were running on older RHEL kernels with ptrace bugs. Hopefully they all run recent enough RHELs now but I did not check (=read /proc/version from *.spec). But besides that the testsuite from Koji was + would be too unrealiable to use as GDB testsuite is very sensitive to machine load. And you cannot guarantee no other rpms get built on the same Koji host as your rpm. So I run the testsuite only on machines under my control using --with testsuite. You may say one may completely drop any testsuite runs from the gdb.spec and run it all only externally from some extra scripts. But that is inconvenient for me (and Red Hat QA) as we deal with so many GDB releases for many RH OSes/versions/arches/variants that it is most convenient to keep all the testing pre-requisites + rules in one gdb.spec for the GDB variant under test. > So probably now is clear that with %ifed BuildRequires (like it is now) > everything would be way harder. Just include --with testsuite to Fedora Packaging Guidelines instead of new CheckBuild keyword. I have seen also --with check to be used. Jan _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
