Re: Please test Vagrant 1.9.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 15, 2017, at 10:07 AM, Vít Ondruch wrote:

> First of all, I am still not fond of moving the plugins.json into /usr.

Why is that?  It's like the fontconfig one, which was discussed in FESCo:
https://pagure.io/fesco/issue/1635#comment-51133
and approved:
https://pagure.io/fesco/issue/1635#comment-67306

>  So from now, I keep Vagrant to look for the plugins.json on the
> place, where Vagrant expects it, i.e. at
> /usr/share/vagrant/plugins.json, but this is link to
> /var/lib/vagrant/plugins.json.

Why not just keep it in /usr if that's where upstream already
expects it?

> Basically, if I understand correctly, the %post is not executed by
> rpm-ostree. 

rpm-ostree *does* execute %post.  We actually don't use librpm
for this, but custom code for a few reasons.  We want to have updates
applied *offline* by default into a new root, so we don't want e.g. `systemctl restart foo`
to run.  We currently run every %post in a bubblewrap-based container
with ostree's rofiles-fuse.  https://bugzilla.redhat.com/show_bug.cgi?id=1352154

> In this case, the /usr/share/vagrant/plugins.json neither
> the link to /var/lib/vagrant/plugins.json is created, which should be
> fine for Vagrant. As soon as some Vagrant plugin is installed, the
> %transfiletriggerin kicks in and when the file/link is not present, it
> just creates the /usr/share/vagrant/plugins.json. 

rpm-ostree doesn't execute %transfiletriggerin though.  We can look
at that, though if vagrant has a %posttrans that regenerated the index,
that'd work in both cases. 

> This way, for normal
> Fedora, the plugin.json would be kept in /var/lib/vagrant/plugins.json
> with symlink to /usr/share/vagrant/plugins.json while for rpm-ostree,
> the /usr/share/vagrant/plugins.json would be regular and the only file.

If that's the end result, that seems sane to me.  Though I don't quite
understand why not just move it to /usr unconditionally, like fontconfig.
 
> Does this work for you? Can you test the latest Copr build [3]?

Yeah, I probably can in a bit.
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux