Re: Fedora mass rebuild 2017

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7 February 2017 at 18:59, Tom Hughes <tom@xxxxxxxxxx> wrote:
> On 07/02/17 23:56, Stephen John Smoogen wrote:
>>
>> On 7 February 2017 at 18:39, Sérgio Basto <sergio@xxxxxxxxxx> wrote:
>>>
>>> Hi,
>>> On Ter, 2017-02-07 at 22:32 +0100, Marek Polacek wrote:
>>>>
>>>> some C++ FE changes (especially the "Fix type-dependence
>>>> and the current instantiation" changes made the compiler to reject
>>>> invalid code
>>>> that had previously been accepted, plus invalid conversions with '\0'
>>>> are now
>>>> rejected)
>>>
>>>
>>> Thanks for exhaustive explanation .
>>> I have this case, how we fix ?
>>> src/rtphint.cpp:342:35: error: ISO C++ forbids comparison between
>>> pointer and integer [-fpermissive]
>>>                      if (pSlash != '\0') {
>>>
>>
>> Someone would need to see more code than that. How is pSlash declared?
>> What is the context of the code you have quoted?
>
>
> Well I'm guessing it's a pointer to char and that should probably be:
>
>   if (*pSlash != '\0')
>
> That's nothing to do with gcc 7 though as gcc 6 should also have objected to
> that code.

Yeah.. I just wanted to make sure as sometimes people do strange
pointer comparisons and I didn't know how long the code had not
compiled.

Thanks for the tip.

> Tom
>
> --
> Tom Hughes (tom@xxxxxxxxxx)
> http://compton.nu/
>
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx



-- 
Stephen J Smoogen.
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux