Hello, Dan Horák <dan@xxxxxxxx> a écrit: > one more case for enabling libabigail tests in bodhi ... Well, task-abicheck that is automatically run on all koji builds actually *caught* this issue. I can see that in the taskotron logs from 2016-08-12 at: https://taskotron.fedoraproject.org/resultsdb/results?page=25&testcase_name=dist.abicheck. It says for libjasper that are changes that need inspection: 8650382 | 2016-08-12 | 06:32:26.472247 | dist.abicheck | NEEDS_INSPECTION | Time taken: 4.26 second(s) | jasper-1.900.1-33.fc23 When I look in the logs themselves at https://taskotron.fedoraproject.org/artifacts/all/532e5e32-6055-11e6-b56f-525400120b80/task_output/jasper-1.900.1-33.fc24.log, I can see this lines in particular: * ABI changes found between jasper-libs-1.900.1-32.fc24.x86_64.rpm and jasper-libs-1.900.1-33.fc24.x86_64.rpm. ABI comparison took 1.10 second(s). Please review them. [...] [C]'function char* jas_stream_gets(jas_stream_t*, char*, int)' at jas_stream.c:573:1 has some indirect sub-type changes: parameter 3 of type 'int' changed: entity changed from 'int' to compatible type 'typedef size_t' at stddef.h:216:1 At the moment, the ABI changes that are reported do not trigger the blocking of the build, so we need collaboration from critpath package maintainers. Whenever Taskotron says "please review this ABI change", the review is needed. I hope this helps. Cheers, -- Dodji -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
