On Tue, Sep 13, 2016 at 11:32:26AM +0200, Florian Weimer wrote: > On 09/12/2016 08:55 PM, Richard W.M. Jones wrote: > >On Mon, Sep 12, 2016 at 07:48:31PM +0100, Richard W.M. Jones wrote: > >>On Mon, Sep 12, 2016 at 09:06:59AM +0200, Florian Weimer wrote: > >>>I had a brief look at the glibc patches. Apparently, off_t and > >>>time_t are 32-bit. For a new architecture, that's quite strange. > > > >How do you determine this? > > I looked at the patch. > > >I wrote a simple program which prints sizeof (off_t) and sizeof (time_t) > >inside the RISC-V environment. I *didn't* define > >`-D_FILE_OFFSET_BITS=64' when compiling the program. Both values are > >printed as 8 (bytes). So it seems we're OK? > > Yes, for 64-bit. But the 32-bit parts do not look acceptable as-is. Fair enough. For Fedora we are only building for 64 bit[1]. There aren't even multilib 32 bit libs. (I'm not saying someone couldn't come along and add that later, but initially we're not considering it) The reasons for this are: - There is no legacy of 32 bit code to support. - By the time this is available, people will care even less about 32 bit. - I've even talked to embedded manufacturers who intend to jump straight to RV64 (which surprised me because RV32 is designed for embedded uses). > If you only want the 64-bit architecture, then getting the author to > submit only the 64-bit parts first to glibc upstream would be the > prudent thing to do. (This has to come from the patch author, and > the author has to assign copyright to the FSF.) I've been telling everyone who will listen that they should get their changes upstream. Rich. [1] Specifically for "RV64G" = "RV64IMAFD" = RISC-V, 64 bit with Integer, Multiplication/division, Atomics, single Floats, and Double floats. For more info, see section 10.4 in this document: https://people.eecs.berkeley.edu/~krste/papers/riscv-spec-2.0.pdf -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
