On Wed, Jun 01, 2016 at 11:57:27AM -0600, Orion Poplawski wrote: > The -D_FORTIFY_SOURCE=2 macro is added with -Wp,-D_FORTIFY_SOURCE=2. The only > notes as to why that I can find are: > > commit 1518ff2d14377c05ecf7cf9428e42964516883b4 > Author: Elliot Lee <sopwith@xxxxxxxxxx> > Date: Wed Feb 9 15:09:11 2005 +0000 > > Fix java builds > > +* Wed Feb 9 2005 Elliot Lee <sopwith@xxxxxxxxxx> 8.0.33-1 > +- Change -D to -Wp,-D to make java happy > > I've testing building java with just the -D version, and it seems fine: If it is because of Java, then it surely has been because of gcj, not openjdk, which didn't exist at that point. But it could very well be also because of many other languages where preprocessing isn't performed and -D* makes no sense, -Wp, on the other side, being a driver option, is something that is accepted for all languages. > https://copr.fedorainfracloud.org/coprs/orion/fortify/builds/ > > So I'd like to change it back. The reason is that ccache does not handle -Wp > options well, and it puts it out of "direct-mode" which triggers an extra run > of the pre-processor. Then perhaps fix or nuke ccache? It is majorly broken anyway, as it doesn't preprocess with -fdirective-only, therefore breaks lots of diagnostics etc. Jakub -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
