Re: orphaning dx (OpenDX)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dominik 'Rathann' Mierzejewski wrote:
> Well, in this case, an array of char is initialised with values > 128
> and the passed to XCreatePixmapFromBitmapData, which requires a char *
> parameter, so it's not trivial (at least to me).

These narrowing issues are all trivial to fix:
export CXXFLAGS="%{optflags} -Wno-error=narrowing"

That said, in this case, you should at least check whether the code does not 
actually want to be compiled with -funsigned-char instead. (I.e., is it only 
building that char array to pass it to XCreatePixmapFromBitmapData, or is it 
trying to read values from this or other char arrays and expecting them to 
come back out as unsigned? In the former case, -Wno-error=narrowing is 
enough, in the latter case, the code was never right and needs either
-funsigned-char or some deeper fixing.)

        Kevin Kofler
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux