On Tue, 26 Jan 2016 10:18:08 +0000 Peter Robinson <pbrobinson@xxxxxxxxx> wrote: > >> > So it appears this thread was probably not enough. Which keeps > >> > us with interesting state where mock by default does not install > >> > weak dependencies where Koji installs them. It causes > >> > interesting issues already. > >> > >> mock/koji not installing weak dependencies == anything wanting ruby > >> being broken. > >> > >> Reason: "ruby" suggests "rubypick" which suggests "ruby". > >> > >> Packages buildrequire "ruby" but do not get "rubypick" installed > >> (or if they are lucky they get) so are unable to find Ruby because > >> there is no "/bin/ruby" executable. > > > > If ruby needs ruby-pick to work, then ruby-pick must not be a weak > > dependency of ruby, but a hard one. > > > > The koji buildroot really should only install hard dependencies. The > > buildroot is supposed to be the minimal possible set needed to build > > the package. If a package that would be installed as a weak > > dependency of one of the build dependencies is needed to build the > > package, that packa is a build dependency too. > > That's incorrect. EG a package has optional Ruby bindings, it doesn't > need ruby to build but if ruby isn't present the ruby binding sub > package is empty. The buildroot should have all that is needed to > build the desired functionality, nothing more nothing less. +1, distribution buildsystem should include all needed deps, including weak, to build full featured result, but the users then can decide if they want the bare minimum or to include some the weak deps. Dan -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
