Hi, Antonio.
Unfortunately there are a couple of things wrong with this commit.
On Wednesday, 09 December 2015 at 18:03, notifications@xxxxxxxxxxxxxxxxx wrote:
> From f8883a63c1d39de2119e00f3233df3ae2ee9c895 Mon Sep 17 00:00:00 2001
> From: sagitter <sagitter@xxxxxxxxxxxxxxxxx>
> Date: Wed, 9 Dec 2015 18:03:05 +0100
> Subject: Built with Python3
>
> ---
> python-biopython.spec | 168 ++++++++++++++++++++++++++++++++++++++++----------
> sources | 2 +-
> 2 files changed, 138 insertions(+), 32 deletions(-)
>
> diff --git a/python-biopython.spec b/python-biopython.spec
> index 7f35631..94bdeff 100644
> --- a/python-biopython.spec
> +++ b/python-biopython.spec
[...]
> +%if 0%{?with_python3}
> +rm -rf %{py3dir}
> +cp -a . %{py3dir}
> +%endif # with_python3
I'm not sure where you got the idea to use py3dir, but it's no longer in
the guidelines and its usage is not the best idea. If it's not possible
to build for both python2 and python3 runtimes from the same source dir,
then you should build both under rpm build dir, while %{py3dir} is
actually one level up.
[...]
> %changelog
> -* Tue Dec 08 2015 Luis Bazan <lbazan@xxxxxxxxxxxxxxxxx> - 1.66-1
> -- new upstream version
> +* Wed Dec 09 2015 Antonio Trande <sagitter@xxxxxxxxxxxxxxxxx> - 1.66-2
> +- Built with Python3
> +- Some cleanups
> +- Set --cflags
> +- Fixed MySQL dependencies in Fedora
> +
> +* Tue Dec 08 2015 Luis Bazan <lbazan@xxxxxxxxxxxxxxxxx>
> +- 1.66-1 - new upstream version
>
> -* Thu Jun 18 2015 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 1.65-2
> -- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
> +* Thu Jun 18 2015 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx>
> +- 1.65-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
>
> * Thu Jan 08 2015 Luis Bazan <lbazan@xxxxxxxxxxxxxxxxx> - 1.65-1
> - New upstream version
> @@ -180,11 +286,11 @@ rm -rf $RPM_BUILD_ROOT
> - Used "MIT" as short license name as the "Biopython License
> Agreement" is the same as the CMU MIT variant.
Why are you modifying existing changelog entries?
> diff --git a/sources b/sources
> index 963f54c..b7a0248 100644
> --- a/sources
> +++ b/sources
> @@ -1 +1 @@
> -2f09afb0a7740a70f64b6d10dfc2582b biopython-1.66.tar.gz
> +d3f4c14e5cba3dfd354d0e0013bc350f biopython-1.66.tar.gz
Why is the checksum different?
Regards,
Dominik
--
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
