Re: [HEADS-UP] Please test kdbus in Rawhide!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Sat, Aug 1, 2015 at 12:26 AM, Orion Poplawski <orion@xxxxxxxxxxxxx> wrote:
> On 07/31/2015 11:07 AM, David Herrmann wrote:
>> Hi
>>
>> On Fri, Jul 31, 2015 at 6:47 PM, Orion Poplawski <orion@xxxxxxxxxxxxx> wrote:
>>>
>>> Cannot log into KDE with kdbus, I get:
>>>
>>> $ cat .xsession-errors
>>> startkde: Starting up...
>>> startkde: Could not sync environment to dbus.
>>
>> This is UpdateActivationEnvironment() failing. This call definitely
>> works and we use it on our machines. However, it returns an error if
>> the argument-array is empty. I fixed this in -git now [1]. It sounds
>> like you're hitting this. If the fix doesn't help, please let me know
>> (should be in rawhide by tomorrow).
>>
>> Thanks a lot for the report!
>> David
>>
>> [1] https://github.com/systemd/systemd/commit/b2a0ac5e5b29c73ca7c0da23369a4769d5a91ddd
>>
>
> This still seems to be failing with systemd-224-1.fc24.x86_64
>
> sendmsg(4, {msg_name(0)=NULL,
> msg_iov(2)=[{"l\1\0\1<\21\0\0\2\0\0\0\223\0\0\0\1\1o\0\25\0\0\0/org/freedesktop/DBus\0\0\0\6\1s\0\24\0\0\0org.freedesktop.DBus\0\0\0\0\2\1s\0\24\0\0\0org.freedesktop.DBus\0\0\0\0\3\1s\0\33\0\0\0UpdateActivationEnvironment\0\0\0\0\0\10\1g\0\5a{ss}\0\0\0\0\0\0",
> 168}, {"4\21\0\0\0\0\0\0\22\0\0\0BASH_FUNC_module()\0\0)\0\0\0() {  eval
> `/usr/bin/modulecmd bash

You export a variable called 'BASH_FUNC_module()' (which is how bash
names its exported functions since the ShellShock updates). According
to POSIX, names of environment variables should only contain
[A-Za-z0-9_], which is what systemd enforces. Hence, systemd refuses
the trailing parantheses in this name.

Anyway, POSIX also explicitly says that applications should tolerate
any other character (except '='). This needs to be fixed in pid1.

Thanks
David
-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux