Re: Review Swap?

[Dave Johansen <davejohansen@xxxxxxxxx>]

On Wed, Jul 8, 2015 at 10:15 AM, Antonio Trande <anto.trande@xxxxxxxxx> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 07/08/2015 07:08 PM, Dave Johansen wrote:
> I have two reviews that have been waiting for a reviewer for a
> while. I would be willing to do a review swap but I would probably
> have a slow turn around on my end (I'm currently on vacation and
> only occasionally get time to do this sort of thing). So if you're
> willing to swap or do the review, then please let me know.
> cppformat: https://bugzilla.redhat.com/show_bug.cgi?id=1216279
> hgsubversion: https://bugzilla.redhat.com/show_bug.cgi?id=1221459
> Thanks, Dave
>
>

I'm willing to review both your packages.

https://bugzilla.redhat.com/show_bug.cgi?id=1231427

It looks like these two lines are unused and are causing problems because qmake isn't available when they're run:
%global qtinc   %(qmake -query QT_INSTALL_PREFIX)/include
%global qtlib   %(qmake -query QT_INSTALL_PREFIX)/lib

-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct