On Sun, Apr 19, 2015 at 01:36:40PM +0000, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Apr 18, 2015 at 08:45:18PM +0200, Sandro Mani wrote: > > Hi Zbyszek > > > > Could you rebuild libzrtpcpp once more for the most recent gcc abi > > breaks? Need to rebuild sflphone for #1213076. > Hi, > > I rebuilt ccrtp, libzrtcpcpp, dbus-c++ locally (just to be sure). I tried > building sflphone then. It fails because of an error in libzrtpcpp in file > zrtpccrtp.h which tries to include a header file without including the directory > in the list of include dirs. I think a change like: > > - #include <ZrtpQueue.h> > + #include <libzrtpcpp/ZrtpQueue.h> > > (and similar in a few other places) should work. I'll submit that upstream > and try to build with this patch. If it works, I'll rebuild ccrtp, libzrtcpcpp, dbus-c++ > in Fedora. Sounds reasonable? There's an (ugly) upstream patch to add -I/usr/include/libzrtpcpp to the .pc file. It's not the right solution: - previous way to include files (#include <libzrtpcpp/xxx.h>) still works, but now one can also use #include <xxx.h>. Some people will use one some the other. - more importantly, not all header files installed by libzrtpcpp are properly namespaced, and this might lead to collisions (for this to work they should all start with Zrtp prefix or something). But upstream wants to include it the next release (https://github.com/wernerd/ZRTPCPP/pull/17), so I think it's fine as a stop-gap solution. I pushed the patch and rebuild ccrtp, libzrtpcpp, dbus-c++ now. sflphone also builds fine, but I didn't build it in koji. Zbyszek -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
