On 01/15/2015 05:15 PM, Luke Macken wrote: > On Thu, Jan 15, 2015 at 10:19:19AM +0100, Tomas Hozza wrote: > > Hi all. > > > > When upgrading F20 to F21 using FedUp, some users had a problem > > with some packages not being upgraded (e.g. [1]). The problem was > > caused by broken update path F20 -> F21. > > > > For example in wget's case I pushed updates for the same NVR in F20 > > and F21 with auto-karma. However the wget update for F20 got the > > stable karma and was pushed to stable before the update for F21. > > > > I think bodhi should enforce the update path is not broken and > > hold the update for F20 until the update for F21 is in stable. > > I know I can do it manually and disable auto-karma and push updates > > to stable as they should be. However I think such task should be > > automated. > > > > Would it be possible to enforce such a thing for updates in bodhi? > > The broken upgrade path for the F20 wget update was detected by > Taskotron[0], and then bodhi immediately disabled autokarma[1]. However, > the stable karma threshold was reached about 5 minutes before it was > detected, so it went out anyway. > > Bodhi2 already has Taskotron-based gating baked into the push > process[2], but this specific issue can also be fixed in the current > bodhi1 codebase. Upon Taskotron failure, if the update has already > reached the stable karma threshold, bodhi should revoke the stable > request. I opened an upstream ticket to track this issue[3] > > luke > > [0]: https://admin.fedoraproject.org/updates/FEDORA-2014-17194/wget-1.16.1-2.fc20 > [1]: https://fedorahosted.org/fesco/ticket/1242 https://github.com/fedora-infra/bodhi/pull/41 > [2]: https://github.com/fedora-infra/bodhi/pull/109 > [3]: https://github.com/fedora-infra/bodhi/issues/116 > > > Thank you for creating the ticket. Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct