Re: [lapack] Use generic macro to detect 64 bit platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/14/2014 05:57 AM, Jerry James wrote:
On Mon, Oct 13, 2014 at 6:00 PM, Peter Robinson
<pbrobinson@xxxxxxxxxxxxxxxxx> wrote:
commit 1c07fc6e86ce11c81da77ac6c55b934594f25bee
Author: Peter Robinson <pbrobinson@xxxxxxxxx>
Date:   Tue Oct 14 01:00:36 2014 +0100

     Use generic macro to detect 64 bit platforms

  lapack.spec |    7 +++++--
  1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/lapack.spec b/lapack.spec
index 0be11ec..c323757 100644
--- a/lapack.spec
+++ b/lapack.spec
@@ -1,7 +1,7 @@
  %global shortver       3
  %global mediumver      %{shortver}.5

-%ifarch x86_64 ppc64
+%if %{__isa_bits} == 64
  %global arch64 1
  %else
  %global arch64 0

I have used this approach in some spec files myself, but I recently
read that the %{__isa_bits} macro is not necessarily defined for all
64-bit platforms, just for those that are multiarch; i.e., that have a
32-bit variant [1].Is this true for Fedora?  Do we support any
platforms for which %{__isa_bits} is NOT defined?

[1] says no such thing, the isa macros are defined for all architectures except obviously noarch. Perhaps you're misinterpreting the example on 64bit package requiring a 32bit package which warns that not all 64bit architectures multiarch.

Even if we don't
now, is there any possibility that we will in the future?  It sure
would be nice to have a macro we can rely on to distinguish between
32-bit and 64-bit platforms for some packages.

That is exactly what __isa_bits is for.

	- Panu -


Footnotes:
[1] http://www.rpm.org/wiki/PackagerDocs/ArchDependencies


--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux