2014-04-28 0:02 GMT+02:00 Andrew Price <anprice@xxxxxxxxxx>:
Generally no. Been there, done that. On 24/04/14 15:13, Lennart Poettering wrote:
We probably should make setjmp()-freeness a requirement for
all code included in Fedora.
Would it be worth the effort, and how feasible is it anyway?
Avoiding setjmp() involves touching well over 75% lines of affected code to add explicit alternative return paths. The result might be cleaner but this is so radical a change that it is also very likely to introduce new bugs. As far as cleanups go, this is on the very end of the "you'd be crazy to do it in Fedora other than doing it upstream and rebasing" scale.
(OTOH if the code is using setjmp() and also using it incorrectly, there's no other practical thing to do than to do such a huge line-by-line rewrite.)
Mirek
-- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
