On 25 February 2014 11:19, Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> wrote:
On 02/25/2014 11:45 AM, Alexander Todorov wrote:Commenting why tests are skipped is a very good thing, but I don't like
> 3) Another proposal (sorry don't remember who proposed it) was to have
> %check with a comment why the test suite is not executed (e.g. requires
> network) or why it is executed in %build.
the idea of adding empty %check sections to my 250+ packages just for
the sake of documenting that tests are ran in %build "because that's
what we do in Java world".
Agreed, it seems like busy work to me that adds very little value to anyone familiar with Java packages. Wouldn't it be easier to change the whatever tool is generating this report to accommodate for this? "If package invokes %mvn_build then don't expect there to be a %check section" seems like a reasonable heuristic to me.
-- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
