On Thu, Feb 27, 2014 at 11:18 AM, Alexander Todorov <atodorov@xxxxxxxxxx> wrote: > На 26.02.2014 15:56, David Howells написа: > >> Alexander Todorov <atodorov@xxxxxxxxxx> wrote: >> >>> How about making %check a packaging requirement in all cases - run tests >>> or >>> add a comment explaining why not, how to run them (e.g. make test) or why >>> there are no tests for this package. >> >> >> Does %check install the package and run the tests as root? For the >> keyutils >> package that I maintain, this would be a requirement to be able to run the >> testsuite because: >> >> (1) There are certain operations that cannot be tested if you're not >> root. >> >> (2) The kernel must be able to upcall to executables installed by the >> rpm. >> >> I imagine this applies to some other packages also. >> > > I does, but not sure to how many. %check is executed during rpmbuild time > right after %build so limitations apply. s/%build/%install/ https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25check_section > > -- > Alex > > > -- > devel mailing list > devel@xxxxxxxxxxxxxxxxxxxxxxx > https://admin.fedoraproject.org/mailman/listinfo/devel > Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
