On Mon, Jan 06, 2014 at 11:04:39AM -0700, Tim Flink wrote: > > What about including them in the RPMs themselves, in a new section > > similar to the existing %check -- or just in a standard file location > > (so no changes to RPM itself are needed immediately)? > I'm not sure that I see how including more stuff than %check during > build is an advantage. > In my mind, %check is for running upstream's unit test suite at build > time, which is an appropriate and useful thing to do. However, I don't > think that running any functional or integration tests at build time is > the best approach. It just doesn't fit into what koji does and seems > like a dirty hack at best, asking for a world of hurt without > significant tangible benefit at worst. Yeah, I wasn't suggesting that they'd be run at build time, just that it might be nice to bundle them with the RPMs that they're supposed to apply to. This has some nice advantages in making them easy to find for anyone rpm-savvy, and makes it clear which tests match up to which code, without having to track that separately somehow. > that we're looking at, I don't see much utility in discussing those > specifics yet - who knows what will change by the time we started > implementing the code to actually run the checks. Yep, fair enough. Just throwing it out there. -- Matthew Miller -- Fedora Project -- <mattdm@xxxxxxxxxxxxxxxxx> -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
