Re: File conflict when upgrading package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mattias Ellert wrote:
>   os.execute("rm -rf %{_datadir}/applications/%{name}.desktop")

Ewww… Using os.execute in Lua scriptlets is scary because the whole point of 
writing them in Lua rather than shell is to avoid depending on stuff being 
installed on the file system. Now in this case, you'll likely get away with 
it because your scriptlet runs the rm only if the directory existed to begin 
with, which is not the case in the "initial installation" use case where 
things like rm are unavailable. Still, actually deleting things from within 
Lua would be cleaner (but likely more work to do recursively, sure; it'd 
help if RPM exported some rm_rf or so function to Lua scriptlets).

        Kevin Kofler

-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux