On 02.11.2013 18:18, Kevin Kofler wrote:
Hi,
Sandro Mani wrote:
%define do_build() \
mkdir build_win%{1}_%{2}; \
(cd build_win%{1}_%{2}; \
%{mingw%{1}_qmake_%{2}} 'PREFIX=%{mingw%{1}_prefix}'
'TARGET=quazip-%{2}' ../libquazip; \
%{mingw%{1}_make} %{?_smp_mflags}; \
)\
%{nil}
Ewww!
Sorry to rain on your parade, but are you sure this (and with the fix for
the nested expansion, it becomes even more ugly) is compatible with the
"spec files must be legible" packaging guideline?
That is a valid point. I don't know what is better, to have 400 lines of
nearly identical copy-paste code (which need to be updated consistently
when something changes) or this. I personally find the compact version
far easier to maintain. But I have not put the package up for review
yet(*), so if I end up doing so, the issue can be revisited.
(*) The reason being that the static version of the library gives me
"bad reloc address 0x18 in section
`.text$_ZN7QStringC1EPKc[__ZN7QStringC1EPKc]'" when trying to link
against it, whereas the native linux version works just fine, and I have
no idea what is going on.
Sandro
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
