Re: Review swap: python-jsmin, python-cssmin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 04, 2013 at 08:41:55AM -0400, Martin Krizek wrote:
> ----- Original Message -----
> > From: "Stephen Gallagher" <sgallagh@xxxxxxxxxx>
> > To: "Development discussions related to Fedora" <devel@xxxxxxxxxxxxxxxxxxxxxxx>
> > Cc: "Martin Krizek" <mkrizek@xxxxxxxxxx>
> > Sent: Friday, October 4, 2013 2:33:50 PM
> > Subject: Re: Review swap: python-jsmin, python-cssmin
> > 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On 10/04/2013 07:57 AM, Martin Krizek wrote:
> > > Hi,
> > > 
> > > anyone willing to review or swap reviews?
> > > 
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1014607
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1014601
> > > 
> > > Thanks! Martin
> > > 
> > 
> > Has JSMin finally changed to an acceptable license? It's got a long
> > history of including a line "The Software shall be used for Good, not
> > Evil." which makes the license unenforceable and unsuitable for
> > inclusion in Fedora.
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.14 (GNU/Linux)
> > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> > 
> > iEYEARECAAYFAlJOta4ACgkQeiVVYja6o6MNlgCgg9HhrfMX9xuMjU6pnV3ptA0+
> > wKkAn247tK9UiqmLyX5xUAfPq4o9ZeCa
> > =Y1cL
> > -----END PGP SIGNATURE-----
> > 
> 
> It's MIT.
> 
This isn't quite so sinple.  jsmin/__init__.py has this at the top:

# This code is original from jsmin by Douglas Crockford, it was translated to
# Python by Baruch Even. It was rewritten by Dave St.Germain for speed.
#
# The MIT License (MIT)
#
# Copyright (c) 2013 Dave St.Germain
#


The original code by Douglas Crockford has the problematic license.
The Baruch Even port had several issues: (1) it appeared to retain the same problematic license.
(2) It was deemed a '"conscious" translation from C to Python' and therefore
retians the original license:
http://www.redhat.com/archives/fedora-legal-list/2009-September/msg00014.html
http://www.redhat.com/archives/fedora-legal-list/2009-August/msg00000.html


That thread talks about a clean-room implementation being okay for
inclusion.  The python-jsmin that you're packaging is most likely not
a clean-room implementation (the header says this is a rewrite of the
previous iterations of the code and thus the author probably started by
reading and modifying the existing code).  I do not know if there's other
legal ways to produce something that the Author would be allowed to
relicense from the original Crockford license to MIT.  You'll need to
contact fedora legal https://admin.fedoraproject.org/mailman/listinfo/legal
to find out for sure but from past reading, I'm not hopeful that there's any
legal way that they could do that (so you might want to contact the
author/pypi owner to let them know that the header and pypi listing are
inaccurate.)

Note that there's other implementations of jsmin.  For instance, the
v8-devel package in Fedora has a clean-room implementation
/usr/lib/python2.7/site-packages/jsmin.py

As a tangent, maybe someone should ask the v8 packager to split that out
into its own subpackage.  The python code doesn't need the v8 package at
runtime.

I've blocked your python-jsmin review bug on FE-LEGAL.  Please close if you
decide not to pursue this package review or update the bug as information
comes in from FE-LEGAL.

-Toshio

Attachment: pgpaqjDy2fa04.pgp
Description: PGP signature

-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux